1479874 - On Windows 10, menu bar items shouldn't change their color when becoming active

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

... because we're using a custom background color on the menu item to darken or lighten the title bar background.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1479874 - On Windows 10, let active menu bar items inherit their color from the title bar.

Review commit: https://reviewboard.mozilla.org/r/260520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260520/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8996420 [details]
Bug 1479874 - On Windows 10, let active menu bar items inherit their color from the title bar.

https://reviewboard.mozilla.org/r/260520/#review267618

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3efc7cdca0c
On Windows 10, let active menu bar items inherit their color from the title bar. r=Felipe

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d3efc7cdca0c

Comment 6

[Oana Botisan, Desktop QA]

Can you please attach an image with the issue or please tell me to which items from the menu bar you are referring to? Because I can't seem to reproduce the issue. I used Nightly from 2018-07-31, but the items "File", "Edit" View"... have the same behaviour like on beta 63.0b11 (they don't change color).