1479914 - Choppy cursor movements in google translate forms

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P2)

Description

[[:philipp]]

we got a user report at https://www.camp-firefox.de/forum/viewtopic.php?f=7&t=125738 about cursor movement getting choppy on multi-line input fields on https://translate.google.com.
in the forum thread mozregression narrowed down this behaviour to bug 1475413 and disabling layout.display-list.retain fixes the problem.

i can reproduce this on windows:
- visit https://tinyurl.com/yacymkxz
- place the cursor in the first line of the left text input panel
- keep pressing the right-arrow key
- once the cursor moves down into the second line the movement is no longer smooth and it's jumping through text rather unpredictable

Comment 1

[Pascal Chevrel:pascalc]

I can also repro on linux and also noticed in Twitter and Google docs that the back arrow keys was reacting slower lately. Tracking as the sites affected are prominent.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1479914 - Always use the new caret display item when available as these can change without an invalidation.

Review commit: https://reviewboard.mozilla.org/r/261160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261160/

Comment 3

[Miko Mynttinen]

Comment on attachment 8997368 [details]
Bug 1479914 - Always use the new caret display item when available as these can change without an invalidation.

https://reviewboard.mozilla.org/r/261160/#review268218

LGTM.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfd4ba48b967
Always use the new caret display item when available as these can change without an invalidation. r=miko

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/dfd4ba48b967

Comment 6

[Ciprian Georgiu, Desktop QA]

Reproduced this issue using STR from comment 0, on an affected Nightly build (2018-07-31).

I cannot see the issue anymore on latest Beta 63.0b11 (20181001131022) across platforms: Win 7 x64, macOS 10.13 and Ubuntu 16.04 x64.