Closed Bug 1479939 Opened 2 years ago Closed 2 years ago

Properly remove compositable pipeline in ClearResources

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Spinoff from https://bugzilla.mozilla.org/show_bug.cgi?id=1452513#c31:

The one discrepancy I see between ClearResources and ProcessWebRenderParentCommands is that the latter also removes the compositable pipeline [1] whereas the former does not [2]. However we can fix that pretty easily by also removing the pipeline in ClearResources.

[1] https://searchfox.org/mozilla-central/rev/a80651653faa78fa4dfbd238d099c2aad1cec304/gfx/layers/wr/WebRenderBridgeParent.cpp#1089
[2] https://searchfox.org/mozilla-central/rev/a80651653faa78fa4dfbd238d099c2aad1cec304/gfx/layers/wr/WebRenderBridgeParent.cpp#1662-1665
Priority: -- → P3
Comment on attachment 8997006 [details]
Bug 1479939 - Ensure we tell WR to remove the compositable pipelines when clearing resources.

https://reviewboard.mozilla.org/r/260978/#review268150

Good catch!
Attachment #8997006 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcea9f4775fa
Ensure we tell WR to remove the compositable pipelines when clearing resources. r=sotaro
https://hg.mozilla.org/mozilla-central/rev/dcea9f4775fa
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.