Closed
Bug 1479995
Opened 7 years ago
Closed 7 years ago
Rename ScrollbarStyles to ScrollStyles
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
ScrollbarStyles nowadays contains values of overflow, scroll-behavior, overscroll-behavior, scroll-snap properties. The only one which is marginally related to scrollbar is overflow, which can be used to hide scrollbar (by making an element not scrollable) or enforce the scrollbar to display.
I believe it makes more sense to be called ScrollStyles as it's mainly concerning behavior of scrolling, not scrollbar. Also, with the emerging of scrollbar color properties and scrollbar-width, the current name can be confusing.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996612 [details]
Bug 1479995 - Rename ScrollbarStyles to ScrollStyles.
https://reviewboard.mozilla.org/r/260716/#review267906
::: layout/base/nsPresContext.h:1362
(Diff revision 1)
> // this element is removed from the document. (For <body> and the root
> // element, this call happens in nsCSSFrameConstructor::ContentRemoved(). For
> // fullscreen elements, it happens in the fullscreen-specific cleanup invoked
> // by Element::UnbindFromTree().)
> - mozilla::dom::Element* MOZ_NON_OWNING_REF mViewportScrollbarOverrideElement;
> - ScrollbarStyles mViewportStyleScrollbar;
> + mozilla::dom::Element* MOZ_NON_OWNING_REF mViewportScrollOverrideElement;
> + ScrollStyles mViewportScrollStyle;
Calling this mViewportScrollStyles (with an s at the end) would be more consistent with the other uses, I think. I don't feel strongly about it.
Attachment #8996612 -
Flags: review?(mstange) → review+
| Comment hidden (mozreview-request) |
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d363b70ff752
Rename ScrollbarStyles to ScrollStyles. r=mstange
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•