1480021 - Provide valgrind suppression file

Status: NEW

(NSS :: Libraries, enhancement, P2)

Description

[Jakub Jelen]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180710113641

Steps to reproduce:

Building applications with NSS prevents running any reasonable memory checker since NSS emits many warnings.


Actual results:

Too many valgrind (maybe false positive?) warnings when running application using NSS under memory checker.


Expected results:

Other libraries provide a suppression file, which help to debug them without investigating the unrelated library issues.

I was trying to put one together, which is yet unfortunately incomplete, but review and maintenance of this file by NSS developers would make more sense than carrying one in each project:

https://gitlab.freedesktop.org/spice/libcacard/commit/3b4b3a3

Comment 1

[Franziskus Kiefer [:franziskus]]

If you put up a patch against NSS, it can get reviewed and landed upstream.

Comment 2

[Jakub Jelen]

Attachment: Proposed suppression file

Thank you for the answer.

I am explicitly adding our suppression file we are currently using in previously referenced libcacard as attachment. I did not find one in the tree (if you have one, please, point me to that).

It is probably up to you where you land this file or where it should be installed. For the reference, the glib installs it in /usr/share/glib-2.0/valgrind/ for us.

This is something that "Works for us" to have "clean" memory footprint and real issues from our code are detected, but will probably not work for other use cases and workloads (but can be extended by others later). Some issues might even be better to fix than to ignore, but it would require some more investigation and full traces (I might be able to get into that later).

Comment 3

[J.C. Jones [:jcj] (he/they)]

Kevin, can you queue up [checking this over, producing a patch from this and posting the review, deciding whether we should include this somehow in our CI]? P2.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P2'.
:beurdouche, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Marco Castelluccio [:marco]]

We have modified the bot to only consider P1 as high priority, so I'm cancelling the needinfo here.