Closed
Bug 1480036
Opened 7 years ago
Closed 7 years ago
Allow scaling all MSG volume with a pref
Categories
(Core :: Audio/Video: MediaStreamGraph, enhancement, P3)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(3 files, 2 obsolete files)
This is so that it's less annoying when running the tests locally.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Updated•7 years ago
|
Rank: 25
Priority: -- → P3
Comment 4•7 years ago
|
||
Comment on attachment 8996756 [details]
Bug 1480036 - Allow forcing a specific audio output device from a test. r?pehrsons
Andreas Pehrson [:pehrsons] has approved the revision.
https://phabricator.services.mozilla.com/D2609
Attachment #8996756 -
Flags: review+
Assignee | ||
Comment 5•7 years ago
|
||
I can't seem to be able to bend our test infrastructure to only set the loopback devices when needed. i'm going to adopt the following strategy:
- On Linux, we have loopback devices. Force their use in gecko, via a pref, so that we don't mutate/rely on the machine state. This means we can listen to music on a normal audio output device while running the tests.
- On other platforms, scale the volume. This means that we won't be hearing ear-piercing sine waves.
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Comment 7•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8996652 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8996756 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8996652 -
Attachment is obsolete: false
Assignee | ||
Updated•7 years ago
|
Attachment #8996757 -
Attachment is obsolete: true
Comment 8•7 years ago
|
||
Comment on attachment 9001598 [details]
Bug 1480036 - Allow forcing a specific audio output device from a test. r?pehrsons
Andreas Pehrson [:pehrsons] has approved the revision.
Attachment #9001598 -
Flags: review+
Comment 9•7 years ago
|
||
Comment on attachment 9001599 [details]
Bug 1480036 - Stop relying on having the default device set globally. r?pehrsons
Andreas Pehrson [:pehrsons] has approved the revision.
Attachment #9001599 -
Flags: review+
Comment 10•7 years ago
|
||
Comment on attachment 8996652 [details]
Bug 1480036 - Allow scaling all MSG volume with a pref. r?pehrsons
Andreas Pehrson [:pehrsons] has approved the revision.
Attachment #8996652 -
Flags: review+
Comment 11•7 years ago
|
||
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f99a091261f
Allow forcing a specific audio output device from a test. r=pehrsons
https://hg.mozilla.org/integration/mozilla-inbound/rev/352e47aeafac
Stop relying on having the default device set globally. r=pehrsons
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2dc5d8ac9ac
Allow scaling all MSG volume with a pref. r=pehrsons
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3f99a091261f
https://hg.mozilla.org/mozilla-central/rev/352e47aeafac
https://hg.mozilla.org/mozilla-central/rev/f2dc5d8ac9ac
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•