1480054 - Don't allow tree pseudos with arguments in content.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

I don't think we've seen them in the wild looking at bug 1379031. I'll add a pref for this and for the argument version, and see how it goes...

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1480054: Restrict XUL tree-pseudos with args everywhere, and without args on nightly and early-beta. r=xidorn

Comment 2

[Phabricator Automation]

Comment on attachment 8996695 [details]
Bug 1480054: Restrict XUL tree-pseudos with args everywhere, and without args on nightly and early-beta. r=xidorn

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

https://phabricator.services.mozilla.com/D2598

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb51c458444
Restrict XUL tree pseudos on nightly and early-beta. r=xidorn

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset ffb51c458444 (Bug 1480054) for Reftest failures

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ffb51c458444b514fd2b69f55c85410923dfe101&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&selectedJob=192071275

Failure log example: https://treeherder.mozilla.org/logviewer.html#?job_id=192071275&repo=mozilla-inbound&lineNumber=8740

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3a267213644ebd2bc74a89cf7c0ed0a112d40b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37861e92aa13
Restrict XUL tree pseudos on nightly and early-beta. r=xidorn

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/854bba84bd34
Enable the pref in treetwisty-svg-context-paint-1.xul. r=me

Comment 7

[Eliza Balazs [:ebalazs_]]

Backed out 2 changesets (Bug 1480054) for reftest failures in build/tests/reftest/tests/layout/reftests/bugs/664127-1.xul

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=37861e92aa136f95725d408dae4e48b7ca77d71c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=192199246

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=192208055&repo=mozilla-inbound&lineNumber=40904

Backout push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d08917025fe0c6cf2146821dc75f5401fbdb62ec&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61c2b7f9d40a
Restrict XUL tree pseudos on nightly and early-beta. r=xidorn

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/61c2b7f9d40a

Comment 10

[Kohei Yoshino [:kohei]]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/moz-tree-pseudo-elements-have-been-deprecated/

Comment 11

[Chris Mills [:cmills]]

I don't think any changes to the docs are needed on account of this bug. When they are finally unshipped (see https://bugzilla.mozilla.org/show_bug.cgi?id=1379031), we should mention it then.