1480073 - Enable the '-webkit-appearance' alias for '-moz-appearance' for EARLY_BETA_OR_EARLIER

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Jonathan Watt [:jwatt]]

I think we're close to the point where the '-webkit-appearance' alias for '-moz-appearance' (bug 1368555) can be turned on in Nightly to get an early indication of whether or not there are any issues we're unaware of that would block shipping the current implementation.

We should wait for the patches for bug 1428676 to get reviews and land.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: pt 2. Enable the '-webkit-appearance' alias for '-moz-appearance' for EARLY_BETA_OR_EARLIER

I won't land this until I've emailed dev-platform and we've had discussion there, but here's the patch in anticipation that this will happen sooner or later.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8996690 [details] [diff] [review]
pt 2. Enable the '-webkit-appearance' alias for '-moz-appearance' for EARLY_BETA_OR_EARLIER

Review of attachment 8996690 [details] [diff] [review]:
-----------------------------------------------------------------

You need to use NIGHTLY_BUILD instead of EARLY_BETA_OR_EARLIER or change the commit message.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1480073 pt 1. Fix -webkit-appearance in property_database.js. r=emilio

Comment 4

[Phabricator Automation]

Comment on attachment 8997987 [details]
Bug 1480073 pt 1. Fix -webkit-appearance in property_database.js. r=emilio

Emilio Cobos Álvarez (:emilio) has approved the revision.

https://phabricator.services.mozilla.com/D2794

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6a4bc9f4a3d
pt 1. Fix -webkit-appearance in property_database.js. r=emilio

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c6a4bc9f4a3d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bce23509919d
pt 2. Enable the '-webkit-appearance' alias for '-moz-appearance' for EARLY_BETA_OR_EARLIER. r=emilio

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bce23509919d

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Since both patches have landed, does this still need to remain open?

Comment 10

[Jonathan Watt [:jwatt]]

Indeed it does not. Thanks for the reminder.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8997987 [details]
Bug 1480073 pt 1. Fix -webkit-appearance in property_database.js. r=emilio

Emilio Cobos Álvarez (:emilio) has been removed from the revision.

Comment 12

[Chris Mills [:cmills]]

Note for the MDN writer who takes this on. As per https://hg.mozilla.org/integration/mozilla-inbound/rev/bce23509919d, the target release for this is Fx63.

Comment 13

[Chris Mills [:cmills]]

Setting this to DDC. We already mention this on the appearance MDN page, and I've made a quick update to specify that it is enabled in beta for now.

I also added a table row for it in https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features

Comment 14

[Estelle Weyl]

When 64 is released, update https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features