Closed Bug 1480113 Opened Last year Closed 11 months ago

Create BrowsingContextChrome, and move mProcessId to it

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: Nika, Assigned: farre)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Priority: -- → P2
Comment on attachment 8998887 [details] [diff] [review]
0001-Bug-1480113-Split-BrowsingContext-to-Content-and-Chr.patch

Review of attachment 8998887 [details] [diff] [review]:
-----------------------------------------------------------------

::: docshell/base/BrowsingContext.cpp
@@ +18,5 @@
>  #include "nsContentUtils.h"
>  #include "nsThreadUtils.h"
>  
> +namespace {
> +class ChromeBrowsingContext final : public mozilla::dom::BrowsingContext

Why put this within the .cpp file? I'd think we would want to make the type distinction public (so that to get the mProcessId you'd have to call a method to switch to a ChromeBrowsingContext)

@@ +47,5 @@
> +  // Indicates which process owns the docshell.
> +  uint64_t mProcessId;
> +};
> +
> +class ContentBrowsingContext final : public mozilla::dom::BrowsingContext

I don't think there will be any state in content which we won't also want in chrome, so I think we can just use BrowsingContext in content.
Attachment #8998887 - Flags: review?(nika)
Create ChromeBrowsingContext and move parent process specific parts
from BrowsingContext there. After that make sure that all
BrowsingContexts created in the parent process is actually
ChromeBrowsingContexts and all BrowsingContexts in the child processes
are BrowsingContexts.
Comment on attachment 9007755 [details]
Bug 1480113 - Split parent process specific parts out of BrowsingContext

Peter Van der Beken [:peterv] has approved the revision.
Attachment #9007755 - Flags: review+
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1de6dfd1e6ed
Split parent process specific parts out of BrowsingContext r=peterv
https://hg.mozilla.org/mozilla-central/rev/1de6dfd1e6ed
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.