1480131 - AntiTrackingCommon::IsFirstPartyStorageAccessGrantFor() should not grant permission to sub-sub-iframe channels

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Andrea Marchesini [:baku]]

In this bug I want to add a topLevelPrincipal attribute in nsILoadInfo. This will be useful here, but also, in the merging of network.cookie.cookieBehavior and privacy_restrict3rdpartystorage_enabled pref.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: topLevelPrincipal.patch

This patch is for Ehsan, when he is back from PTO.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: topLevelPrincipal.patch

Comment 3

[(no longer active)]

This also needs a test...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dfec7088c60
AntiTrackingCommon::IsFirstPartyStorageAccessGrantFor() should not grant permission to sub-sub-iframe channels; r=ehsan

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6dfec7088c60

Comment 6

[(no longer active)]

Are you planning to write a test for this, Andrea?  Thanks!

Comment 7

[Andrea Marchesini [:baku]]

I already did here:
https://hg.mozilla.org/integration/mozilla-inbound/file/tip/dom/serviceworkers/test/browser_antitracking_subiframes.js

this test creates 2 nested iframes. The first one is controlled, the nested one is not. The 'antitracking' in the name is misleading: there are no trackers involved in that test.

Comment 8

[(no longer active)]

Thanks, great, sorry I didn't see that test!