Closed Bug 1480190 Opened Last year Closed Last year

Flip media.media-capabilities.enabled to true

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: drno, Assigned: jya)

References

(Regressed 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

Bug 1409664 added the media.media-capabilities.enabled, which is set to false. This bug is to keep track of turning the Media capabilities feature to on by default by flipping the above mentioned pref.
Depends on: 1482243
Comment on attachment 8998995 [details]
Bug 1480190 - Enable media-capablities extension by default. r?drno

Nils Ohlmeier [:drno] has approved the revision.
Attachment #8998995 - Flags: review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93aabcabcdf7
Enable media-capablities extension by default. r=drno
Backed out changeset 93aabcabcdf7 (Bug 1480190) for test_interfaces.html failures.

Push with failures:https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=93aabcabcdf717db6d0e0983fa1f8b2add0c42f3

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/efaab64ea46bd43aa70bd7bdcdc654372cd8028b

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193335015&repo=mozilla-inbound&lineNumber=3343

18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface IDBIndex to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface IDBKeyRange to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface IDBObjectStore to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface IDBRequest to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface IDBOpenDBRequest to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface IDBTransaction to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface IDBVersionChangeEvent to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface ImageBitmap to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface ImageBitmapRenderingContext to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface ImageData to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - Buffered messages finished
18:11:17     INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_serviceworker_interfaces.html | undefined: If this is failing: DANGER, are you sure you want to expose the new interface MediaCapabilities to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO -     setupSW/window.onmessage@dom/serviceworkers/test/test_serviceworker_interfaces.html:31:9
18:11:17     INFO -     EventHandlerNonNull*setupSW@dom/serviceworkers/test/test_serviceworker_interfaces.html:19:5
18:11:17     INFO - Not taking screenshot here: see the one that was previously logged
18:11:17     INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_serviceworker_interfaces.html | undefined: If this is failing: DANGER, are you sure you want to expose the new interface MediaCapabilitiesInfo to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO -     setupSW/window.onmessage@dom/serviceworkers/test/test_serviceworker_interfaces.html:31:9
18:11:17     INFO -     EventHandlerNonNull*setupSW@dom/serviceworkers/test/test_serviceworker_interfaces.html:19:5
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface MessageChannel to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface MessageEvent to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface MessagePort to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Notification to all webpages as a property on the service worker? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
18:11:17     INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If thi
Comment on attachment 8998995 [details]
Bug 1480190 - Enable media-capablities extension by default. r?drno

Boris Zbarsky [:bzbarsky, bz on IRC] (vacation Aug 16-27) has approved the revision.
Attachment #8998995 - Flags: review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62e358f53fdd
Enable media-capablities extension by default. r=drno,bzbarsky
Backed out changeset 62e358f53fdd (bug 1480190) for mochitest failures at dom/workers/test/test_navigator.html and dom/workers/test/test_worker_interfaces.html

Backout: https://hg.mozilla.org/integration/autoland/rev/6f7f5d29287391336e33626c88b70ffd4b0222a6

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=62e358f53fdd136cfec7fa7e19d8f9f512dae07d

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193427738&repo=autoland&lineNumber=3672

task 2018-08-11T09:40:50.670Z] 09:40:50     INFO - TEST-START | dom/workers/test/test_navigator.html
[task 2018-08-11T09:40:50.872Z] 09:40:50     INFO - GECKO(2066) | ++DOMWINDOW == 12 (0x7fd8b7cf4800) [pid = 2130] [serial = 127] [outer = 0x7fd8bd9eea00]
[task 2018-08-11T09:40:51.143Z] 09:40:51     INFO - GECKO(2066) | ++DOCSHELL 0x7fd8b7c8b000 == 5 [pid = 2130] [id = {7b37df5d-315e-4bee-919c-d6ed88a673fc}]
[task 2018-08-11T09:40:51.152Z] 09:40:51     INFO - GECKO(2066) | ++DOMWINDOW == 13 (0x7fd8b7cb8600) [pid = 2130] [serial = 128] [outer = (nil)]
[task 2018-08-11T09:40:51.163Z] 09:40:51     INFO - GECKO(2066) | ++DOMWINDOW == 14 (0x7fd8b7cf0400) [pid = 2130] [serial = 129] [outer = 0x7fd8b7cb8600]
[task 2018-08-11T09:40:52.172Z] 09:40:52     INFO - TEST-INFO | started process screentopng
[task 2018-08-11T09:40:53.094Z] 09:40:53     INFO - TEST-INFO | screentopng: exit 0
[task 2018-08-11T09:40:53.094Z] 09:40:53     INFO - Buffered messages logged at 09:40:51
[task 2018-08-11T09:40:53.095Z] 09:40:53     INFO - TEST-PASS | dom/workers/test/test_navigator.html | This test should not be running in a secure context 
[task 2018-08-11T09:40:53.096Z] 09:40:53     INFO - Buffered messages finished
[task 2018-08-11T09:40:53.097Z] 09:40:53     INFO - TEST-UNEXPECTED-FAIL | dom/workers/test/test_navigator.html | Worker had an error: uncaught exception: Navigator has the 'mediaCapabilities' property that isn't in the list! 
[task 2018-08-11T09:40:53.098Z] 09:40:53     INFO -     worker.onerror@dom/workers/test/test_navigator_iframe.js:40:3
[task 2018-08-11T09:40:53.099Z] 09:40:53     INFO -     EventHandlerNonNull*@dom/workers/test/test_navigator_iframe.js:39:1
[task 2018-08-11T09:40:53.100Z] 09:40:53     INFO - GECKO(2066) | MEMORY STAT | vsize 1591MB | residentFast 149MB | heapAllocated 28MB
[task 2018-08-11T09:40:53.102Z] 09:40:53     INFO - TEST-OK | dom/workers/test/test_navigator.html | took 1554ms
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47091a68bf3a
Enable media-capablities extension by default. r=drno,bzbarsky
https://hg.mozilla.org/mozilla-central/rev/47091a68bf3a
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Depends on: 1482847
No longer depends on: 1482847
You need to log in before you can comment on or make changes to this bug.