Allow creating custom elements that extend the specialized XUL element classes.

RESOLVED FIXED in Firefox 63

Status

RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Spinning off from bug 1478139, attempting to convert the <editor> XBL binding to a custom element fails because it must extend XULFrameElement but the code requires XUL elements to only extend XULElement. Normally we'd do this as a custom built-in element, but that would require us to create a custom element that applies to a base <editor> tag with is="". This is solvable by just allowing us to extend the other types.

The attached patch does that. It has the downside that the tag names are hardcoded but for our purposes that is fine.
Blocks: 1397874
Comment on attachment 8996834 [details]
Bug 1480195: Allow writing custom element definitions for the special XUL elements.

Olli Pettay [:smaug] has approved the revision.

https://phabricator.services.mozilla.com/D2430
Attachment #8996834 - Flags: review+
See Also: → bug 1480465

Comment 3

8 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebd853eb196e
Allow writing custom element definitions for the special XUL elements. r=smaug

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ebd853eb196e
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.