1480213 - Preemptively fix unified bustage in layout/base

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Daniel Holbert [:dholbert]]

(Formerly: bug 1468590)

layout/base doesn't quite build successfully right now, when I disable unified builds (by doing s/UNIFIED_SOURCES/SOURCES/ in its moz.build file)

I get this build error (for a .cpp file in layout/base, though note that the problem is actually in a header that it pulls in from layout/style):

=====
In file included from ../../../mozilla/layout/base/nsPresContext.cpp:42:
 ../../../mozilla/layout/style/nsMediaFeatures.h:20:47: error: base class has incomplete type
 struct nsCSSKeywordAndBoolTableEntry : public nsCSSKTableEntry {
=====

Filing this bug on fixing this. nsMediaFeatures.h is just missing an #include that it needs to provide the nsCSSKTableEntry definition.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1480213: Give nsMediaFeatures.h an include for nsCSSProps.h, to provide nsCSSKTableEntry type definition & fix non-unified build bustage. r?TYLin

Comment 2

[Phabricator Automation]

Comment on attachment 8996847 [details]
Bug 1480213: Give nsMediaFeatures.h an include for nsCSSProps.h, to provide nsCSSKTableEntry type definition & fix non-unified build bustage. r?TYLin

Ting-Yu Lin [:TYLin] (UTC-7) has approved the revision.

https://phabricator.services.mozilla.com/D2628

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b62ca7339381
Give nsMediaFeatures.h an include for nsCSSProps.h, to provide nsCSSKTableEntry type definition & fix non-unified build bustage. r=TYLin

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b62ca7339381