Closed Bug 1480315 Opened 3 years ago Closed 3 years ago

coredump caused by getenv since missing header in mozglue/misc/TimeStamp.cpp

Categories

(Core :: mozglue, defect)

Product:
Core
Component:
mozglue
Version:
52 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: changqing.li, Assigned: changqing.li)

Details

Attachments

(1 file)

0001-mozjs-fix-coredump-caused-by-getenv.patch
652 bytes, patch
glandium
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.75 Safari/537.36

Steps to reproduce:

start polkit.service


Actual results:

report failed since segament fault.


Expected results:

service start success.

Here is the bug analyze:
1.  polkit depend on libmozjs-52.so.
2.  during startup polkit,  the call stack is here:
    JS::detail::InitWithFailureDiagnostic  ->mozilla::TimeStamp::ProcessCreation->getenv(MOZ_APP_RESTART)

3.  coredump happened during getenv since missing header stdlib.h,  int convert to char* cause coredump

4.  patch attached
Attachment #8996919 - Flags: review+
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c617268ad37
Fix coredump caused by getenv. r=glandium
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0c617268ad37
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → changqing.li
You need to log in before you can comment on or make changes to this bug.