Closed Bug 1480327 Opened 3 years ago Closed 3 years ago

Get rid of most of Log.jsm

Categories

(Toolkit :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

(Whiteboard: [overhead:20k])

Attachments

(2 files)

Unfortunately, Log.jsm not only still exists, but is also currently loaded into every content process by telemetry.

We should really get rid of it entirely, and ban it in the content process before then. But for now, let's just get rid of all of the ancient, unused cruft it still contains.
Comment on attachment 8996931 [details]
Bug 1480327: Part 1 - Get rid of most of Log.jsm.

https://reviewboard.mozilla.org/r/260918/#review268746
Attachment #8996931 - Flags: review?(dtownsend) → review+
Comment on attachment 8996932 [details]
Bug 1480327: Part 2 - Modernize what's left of Log.jsm a bit.

https://reviewboard.mozilla.org/r/260920/#review268748
Attachment #8996932 - Flags: review?(dtownsend) → review+
Whiteboard: [overhead:20k]
https://hg.mozilla.org/mozilla-central/rev/ffcc2ae2ef83
https://hg.mozilla.org/mozilla-central/rev/af213f409e57
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

(In reply to Kris Maglione [:kmag] (unavailable until 10/28) from comment #0)

Unfortunately, Log.jsm not only still exists, but is also currently loaded
into every content process by telemetry.

Is there a blessed replacement for it?

Flags: needinfo?(kmaglione+bmo)

(In reply to Magnus Melin [:mkmelin] from comment #7)

(In reply to Kris Maglione [:kmag] (unavailable until 10/28) from comment #0)

Unfortunately, Log.jsm not only still exists, but is also currently loaded
into every content process by telemetry.

Is there a blessed replacement for it?

I think console.createInstance is the new wizardry from a discussion I had the other day (and it is much nicer than the logging modules we have).

Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.