1480358 - Page broken on Nightly

Status: VERIFIED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Shai Mishali]

Attachment: Screen Shot 2018-08-02 at 12.13.35 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180801100116

Steps to reproduce:

On Firefox Nightly 63.0a1 (2018-08-01) (64-bit), trying to open the following article presents a broken version of the page: https://www.raywenderlich.com/156794/custom-uicollectionviewlayout-tutorial-parallax

On Firefox 57 there is no issue with that page.


Actual results:

Page is presented as broken (see attachment)


Expected results:

Page should be presented correctly (see attachment).

Comment 1

[Shai Mishali]

Attachment: Valid Presentation on Firefox 57

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=465f6e311e6db2cfda4ca5400c43cbd7ced82619&tochange=f52422f008ed88d270b9af0ba0379e07a7c2268c

Regressed by: f52422f008ed	Xidorn Quan — Bug 1472386 - Take overflow-wrap into account when calculating min-content intrinsic size. r=jfkthame

:xidorn, Can you look into this?

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

This is a silly bug of the implementation of bug 1472386... (i.e. fortunately it is not something broken because of the behavior change).

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

There are actually two bugs around this, but I'll start with the easier one in this bug, and probably file another later.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1480358 - Have the second OptionallyBreak actually make sense. r?jfkthame

Comment 6

[Phabricator Automation]

Comment on attachment 8997254 [details]
Bug 1480358 - Have the second OptionallyBreak actually make sense. r?jfkthame

Jonathan Kew (:jfkthame) has approved the revision.

https://phabricator.services.mozilla.com/D2696

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ffc14b88b8e
Have the second OptionallyBreak actually make sense. r=jfkthame

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12291 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3ffc14b88b8e

Comment 11

[Shai Mishali]

Thanks! Just confirmed on latest nightly (63.0a1 (2018-08-03)) this looks good.

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Thanks for verifying!

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 14

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Updating the tracking flag according to comment 11.