Closed Bug 1480358 Opened 5 years ago Closed 5 years ago

Page broken on Nightly

Categories

(Core :: Layout: Block and Inline, defect)

Product:
Core
Component:
Layout: Block and Inline
Version:
63 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- verified

People

(Reporter: freak4pc, Assigned: xidorn)

References

Details

(Keywords: regression)

Attachments

(3 files)

Screen Shot 2018-08-02 at 12.13.35 PM.png
913.04 KB, image/png
Details
Valid Presentation on Firefox 57
1.12 MB, image/png
Details
Bug 1480358 - Have the second OptionallyBreak actually make sense. r?jfkthame
46 bytes, text/x-phabricator-request
jfkthame
: review+
Details | Review 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180801100116

Steps to reproduce:

On Firefox Nightly 63.0a1 (2018-08-01) (64-bit), trying to open the following article presents a broken version of the page: https://www.raywenderlich.com/156794/custom-uicollectionviewlayout-tutorial-parallax

On Firefox 57 there is no issue with that page.


Actual results:

Page is presented as broken (see attachment)


Expected results:

Page should be presented correctly (see attachment).

    
    

    
  
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=465f6e311e6db2cfda4ca5400c43cbd7ced82619&tochange=f52422f008ed88d270b9af0ba0379e07a7c2268c

Regressed by: f52422f008ed	Xidorn Quan — Bug 1472386 - Take overflow-wrap into account when calculating min-content intrinsic size. r=jfkthame

:xidorn, Can you look into this?
Blocks: 1472386
Status: UNCONFIRMED → NEW

          status-firefox61:
          --- → unaffected

          status-firefox62:
          --- → unaffected

          status-firefox63:
          --- → affected

          status-firefox-esr52:
          --- → unaffected

          status-firefox-esr60:
          --- → unaffected
Component: Untriaged → Layout: Block and Inline
Ever confirmed: true
Flags: needinfo?(xidorn+moz)
Keywords: regression
Product: Firefox → Core

    
    

    
  
This is a silly bug of the implementation of bug 1472386... (i.e. fortunately it is not something broken because of the behavior change).
Assignee: nobody → xidorn+moz
Flags: needinfo?(xidorn+moz)

    
    

    
  
There are actually two bugs around this, but I'll start with the easier one in this bug, and probably file another later.

    
  
Blocks: 1480284

    
    

    
  
Comment on attachment 8997254 [details]
Bug 1480358 - Have the second OptionallyBreak actually make sense. r?jfkthame

Jonathan Kew (:jfkthame) has approved the revision.

https://phabricator.services.mozilla.com/D2696

        Attachment #8997254 -
        Flags: review+

    
    

    
  
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ffc14b88b8e
Have the second OptionallyBreak actually make sense. r=jfkthame

    
    

    
  
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12291 for changes under testing/web-platform/tests

    
    

    
  
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3ffc14b88b8e
Status: NEW → RESOLVED
Closed: 5 years ago

          status-firefox63:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

    
    

    
  
Thanks! Just confirmed on latest nightly (63.0a1 (2018-08-03)) this looks good.

    
    

    
  
Thanks for verifying!
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.