Closed
Bug 1480364
Opened 7 years ago
Closed 7 years ago
AbortSignal doesn't need to keep alive AbortController
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
|
3.70 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8996958 -
Flags: review?(bugs)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8996958 [details] [diff] [review]
abort_0.patch
You can remove way more code.
I guess all the NS_DECL_ and and NS_IMPL_ too, since the class doesn't really add anything to cycle collection.
We can do this simple patch too, but I'd prefer a new patch with more cleanups
Attachment #8996958 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
I haven't removed the CC part because of bug 1480366 where I need it.
|
||
Updated•7 years ago
|
Priority: -- → P3
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56cd87390012
AbortSignal doesn't need to keep alive AbortController, r=smaug
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•