Closed Bug 1480364 Opened Last year Closed Last year

AbortSignal doesn't need to keep alive AbortController

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

No description provided.
Attached patch abort_0.patchSplinter Review
Attachment #8996958 - Flags: review?(bugs)
Blocks: 1478101
Comment on attachment 8996958 [details] [diff] [review]
abort_0.patch

You can remove way more code.
I guess all the NS_DECL_ and and NS_IMPL_ too, since the class doesn't really add anything to cycle collection.

We can do this simple patch too, but I'd prefer a new patch with more cleanups
Attachment #8996958 - Flags: review?(bugs) → review+
I haven't removed the CC part because of bug 1480366 where I need it.
Priority: -- → P3
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56cd87390012
AbortSignal doesn't need to keep alive AbortController, r=smaug
https://hg.mozilla.org/mozilla-central/rev/56cd87390012
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.