Closed Bug 1480428 Opened 6 years ago Closed 6 years ago

Crash in TabDisplayManager.updateTabsFrom (top crasher 13.0-release)

Categories

(Firefox for iOS :: General, defect, P2)

Other
iOS
defect

Tracking

()

VERIFIED FIXED
Tracking Status
fxios 14.0 ---
fxios-v13.1 --- verified

People

(Reporter: garvan, Unassigned)

References

Details

Coalition: org.mozilla.ios.FirefoxBeta [443] Date/Time: 2018-08-01 06:25:23.0545 +0800 Launch Time: 2018-08-01 06:25:03.1422 +0800 OS Version: iPhone OS 12.0 (16A5339e) Baseband Version: 4.04.01 Report Version: 104 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Triggered by Thread: 0 Last Exception Backtrace: 0 CoreFoundation 0x207fc9490 __exceptionPreprocess + 228 (NSException.m:172) 1 libobjc.A.dylib 0x207196a40 objc_exception_throw + 56 (objc-exception.mm:557) 2 CoreFoundation 0x207edd8ec +[NSException raise:format:arguments:] + 104 (NSException.m:136) 3 Foundation 0x2089c4d80 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 112 (NSException.m:157) 4 UIKitCore 0x234fc6904 -[UICollectionView _createPreparedCellForItemAtIndexPath:withLayoutAttributes:applyAttributes:isFocused:notify:] + 1116 (UICollectionView.m:1994) 5 UIKitCore 0x234fc825c -[UICollectionView _prefetchItemsForVelocity:maxItemsToPrefetch:invalidateCandidatesOnDirectionChanges:] + 484 (UICollectionView.m:2250) 6 UIKitCore 0x234fcfb88 -[UICollectionView layoutSubviews] + 736 (UICollectionView.m:3599) 7 UIKitCore 0x2355d3fbc -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1380 (UIView.m:15656) 8 QuartzCore 0x20c751f38 -[CALayer layoutSublayers] + 184 (CALayer.mm:9445) 9 QuartzCore 0x20c756ec8 CA::Layer::layout_if_needed(CA::Transaction*) + 324 (CALayer.mm:9325) 10 UIKitCore 0x2355bf4a8 -[UIView(Hierarchy) layoutBelowIfNeeded] + 548 (UIView.m:10835) 11 UIKitCore 0x234fe64ac -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:animator:] + 248 (UICollectionView.m:7113) 12 UIKitCore 0x234fe6394 -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:] + 96 (UICollectionView.m:7087) 13 UIKitCore 0x234fe6318 -[UICollectionView _performBatchUpdates:completion:invalidationContext:] + 84 (UICollectionView.m:7082) 14 UIKitCore 0x234fe6254 -[UICollectionView performBatchUpdates:completion:] + 64 (UICollectionView.m:7071) 15 Client 0x104c8831c partial apply for closure #3 in TabDisplayManager.updateTabsFrom(_:to:on:) + 148 (TabDisplayManager.swift:397) 16 Client 0x104b76b60 _T0Ieg_IeyB_TR + 36 (AppSettingsTableViewController.swift:0) 17 UIKitCore 0x2355c79cc +[UIView(UIViewAnimationWithBlocks) _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:] + 608 (UIView.m:12880) 18 UIKitCore 0x2355c7f90 +[UIView(UIViewAnimationWithBlocks) animateWithDuration:animations:completion:] + 100 (UIView.m:12944) 19 Client 0x104c849d8 specialized TabDisplayManager.updateTabsFrom(_:to:on:) + 1460 (TabDisplayManager.swift:396) 20 Client 0x104c7ebf4 closure #2 in TabDisplayManager.updateTabsFrom(_:to:on:) + 488 (TabDisplayManager.swift:0) 21 Client 0x104c8834c partial apply for closure #4 in TabDisplayManager.updateTabsFrom(_:to:on:) + 20 (TabDisplayManager.swift:399) 22 Client 0x104b79684 _T0SbIegy_SbIeyBy_TR + 40 (PasscodeViews.swift:0) 23 Foundation 0x208a5fc18 __NSFireDelayedPerform + 404 (NSRunLoop.m:620) 24 CoreFoundation 0x207f58188 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 28 (CFRunLoop.c:1830) 25 CoreFoundation 0x207f57eb8 __CFRunLoopDoTimer + 864 (CFRunLoop.c:2417) 26 CoreFoundation 0x207f576ec __CFRunLoopDoTimers + 248 (CFRunLoop.c:2564) 27 CoreFoundation 0x207f525c8 __CFRunLoopRun + 1880 (CFRunLoop.c:0) 28 CoreFoundation 0x207f51b50 CFRunLoopRunSpecific + 436 (CFRunLoop.c:3247) 29 GraphicsServices 0x20a1c1584 GSEventRunModal + 100 (GSEvent.c:2245) 30 UIKitCore 0x234f26d68 UIApplicationMain + 212 (UIApplication.m:4328) 31 Client 0x104b688c4 main + 224 (main.swift:16) 32 libdyld.dylib 0x207a12188 start + 4
Priority: -- → P2
Note that PasscodeViews.swift:0 is always in the stack trace, I am unsure of the implications of this
Although Sentry isn't symbolicating, the crash matches this one in Xcode organizer.
Summary: iOS 12 Beta: crash in TabDisplayManager.updateTabsFrom → Crash in TabDisplayManager.updateTabsFrom (top crasher 13.0-release)
Catalin, Simon any help reproducing this bug would be appreciated.
Flags: needinfo?(simion.basca)
Flags: needinfo?(catalin.suciu)
The one way I was able to get this to reproduce 1. have a few tabs open in each browsing mode. 2. In normal mode drag a tab around, while holding the tab switch to PBM 3. end the drag 4. Try dragging a tab in PBM 5. crash
See Also: → 1482883
Verifying as fix on 13.1(11724). The crash is no longer reproducible following the STR from comment 4.
Status: RESOLVED → VERIFIED
Flags: needinfo?(simion.basca)
Flags: needinfo?(catalin.suciu)
You need to log in before you can comment on or make changes to this bug.