1480525 - _localIdp and _remoteIdp are not checked before closed in PeerConnection.js

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

_localIdp and _remoteIdp may not exist, when this happens close() will throw an exception and terminate early[0].
Fixing this will fix some exceptions being thrown in the tests, though they are not causing the tests to fail AFAIK.

[0] https://searchfox.org/mozilla-central/source/dom/media/PeerConnection.js#1378

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This happens in the test for bug 1227781, in which the PeerConnection initialization is supposed to fail.

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=067167c89e6060d887de63fb05353f21edb0260f

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1480525 - ensure localIdp, remoteIdp exist before closing them

If PeerConnection initialization terminates early due to an excpetion localIdp, and remoteIdp aren't created.
This causes another exception in close(). The patch checks that they each exist in close before attempting to 
access them.

Comment 4

[Phabricator Automation]

Comment on attachment 8997187 [details]
Bug 1480525 - ensure localIdp, remoteIdp exist before closing them

Michael Froman [:mjf] has approved the revision.

https://phabricator.services.mozilla.com/D2686

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b36bf1368f6
ensure localIdp, remoteIdp exist before closing them r=mjf

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5b36bf1368f6