1480620 - [blob-img] Only filter the portion needed for a particular tile

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

Right now we filter the entire source. This isn't great.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1480620. Add DrawTargetOffset.

This adds a DrawTargetOffset which is basically a simplified
DrawTargetTiled that only supports one tile. It useful for situations
where Cairo's device offset was used previously.

This also replaces WebRender's use of DrawTargetTiled which was just trying to
apply offset.

Review commit: https://reviewboard.mozilla.org/r/261212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261212/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1480620. Clip the filter source rect to the transformed DrawTarget bounds.

This lets us avoid filtering the entire source image when we only need a small portion of it.
This makes a big performance difference with tiled blob images with WebRender.

Review commit: https://reviewboard.mozilla.org/r/261214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261214/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8997458 [details]
Bug 1480620. Clip the filter source rect to the transformed DrawTarget bounds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/261214/diff/1-2/

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8997458 [details]
Bug 1480620. Clip the filter source rect to the transformed DrawTarget bounds.

https://reviewboard.mozilla.org/r/261214/#review268340

::: gfx/2d/DrawTargetOffset.cpp:84
(Diff revision 2)
>  OFFSET_COMMAND3(Mask, const Pattern&, const Pattern&, const DrawOptions&)
>  
>  void
> +DrawTargetOffset::DrawFilter(FilterNode* aNode, const Rect& aSourceRect, const Point& aDestPoint, const DrawOptions& aOptions)
> +{
> +  auto inverse = mTransform.Inverse();

Please handle the case where mTransform is not invertible.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8997458 [details]
Bug 1480620. Clip the filter source rect to the transformed DrawTarget bounds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/261214/diff/2-3/

Comment 6

[Bas Schouten (:bas.schouten)]

Comment on attachment 8997457 [details]
Bug 1480620. Add DrawTargetOffset.

https://reviewboard.mozilla.org/r/261212/#review268884

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a360d3b8f76c
Add DrawTargetOffset. r=bas
https://hg.mozilla.org/integration/autoland/rev/89a67ef04c61
Clip the filter source rect to the transformed DrawTarget bounds. r=mstange

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94117544b4f5
Replace WebRender's use of DrawTargetTiled.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a360d3b8f76c
https://hg.mozilla.org/mozilla-central/rev/89a67ef04c61
https://hg.mozilla.org/mozilla-central/rev/94117544b4f5