Closed Bug 1480620 Opened Last year Closed Last year

[blob-img] Only filter the portion needed for a particular tile

Categories

(Core :: Graphics: WebRender, enhancement, P3)

63 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Right now we filter the entire source. This isn't great.
Blocks: 1455427
Priority: -- → P3
Comment on attachment 8997458 [details]
Bug 1480620. Clip the filter source rect to the transformed DrawTarget bounds.

https://reviewboard.mozilla.org/r/261214/#review268340

::: gfx/2d/DrawTargetOffset.cpp:84
(Diff revision 2)
>  OFFSET_COMMAND3(Mask, const Pattern&, const Pattern&, const DrawOptions&)
>  
>  void
> +DrawTargetOffset::DrawFilter(FilterNode* aNode, const Rect& aSourceRect, const Point& aDestPoint, const DrawOptions& aOptions)
> +{
> +  auto inverse = mTransform.Inverse();

Please handle the case where mTransform is not invertible.
Attachment #8997458 - Flags: review?(mstange) → review+
Comment on attachment 8997457 [details]
Bug 1480620. Add DrawTargetOffset.

https://reviewboard.mozilla.org/r/261212/#review268884
Attachment #8997457 - Flags: review?(bas) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a360d3b8f76c
Add DrawTargetOffset. r=bas
https://hg.mozilla.org/integration/autoland/rev/89a67ef04c61
Clip the filter source rect to the transformed DrawTarget bounds. r=mstange
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94117544b4f5
Replace WebRender's use of DrawTargetTiled.
Assignee: nobody → jmuizelaar
You need to log in before you can comment on or make changes to this bug.