Closed Bug 1480652 Opened 2 years ago Closed Last year

add appropriate aarch64 magic to ServoBindings.toml

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

ARM64
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Going to need this so bindgen works properly.
Priority: -- → P3
This is the LLVM target name that's getting used in https://github.com/rust-lang/rust/pull/53173.
Attachment #8999010 - Flags: review?(xidorn+moz)
Comment on attachment 8999010 [details] [diff] [review]
add an aarch64 windows case to ServoBindings.toml

Review of attachment 8999010 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with this change, but I suspect that this should really call "aarch64-unknown-windows-msvc" rather than "aarch64-pc-windows-msvc" given code in LLVM. I've raised that in the Rust issue.
Attachment #8999010 - Flags: review?(xidorn+moz) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aebd6f51d2e5
add an aarch64 windows case to ServoBindings.toml; r=xidorn
https://hg.mozilla.org/mozilla-central/rev/aebd6f51d2e5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → nfroyd
You need to log in before you can comment on or make changes to this bug.