Closed
Bug 1480652
Opened 6 years ago
Closed 6 years ago
add appropriate aarch64 magic to ServoBindings.toml
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
Going to need this so bindgen works properly.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
This is the LLVM target name that's getting used in https://github.com/rust-lang/rust/pull/53173.
Attachment #8999010 -
Flags: review?(xidorn+moz)
|
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8999010 [details] [diff] [review] add an aarch64 windows case to ServoBindings.toml Review of attachment 8999010 [details] [diff] [review]: ----------------------------------------------------------------- I'm fine with this change, but I suspect that this should really call "aarch64-unknown-windows-msvc" rather than "aarch64-pc-windows-msvc" given code in LLVM. I've raised that in the Rust issue.
Attachment #8999010 -
Flags: review?(xidorn+moz) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aebd6f51d2e5 add an aarch64 windows case to ServoBindings.toml; r=xidorn
|
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aebd6f51d2e5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•