1480688 - Don't try to move eh_frame in case it's not necessary

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1480688 - Don't try to move .eh_frame in case it's not necessary.

If the .eh_frame_hdr and .eh_frame sections are not between the elfhack
relocation and elfhack code sections, it's not going to change anything
to try to move it, so don't even try.

While here, adjust the adjacency test to error out when the section name
doesn't match.

Review commit: https://reviewboard.mozilla.org/r/261154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261154/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8997345 [details]
Bug 1480688 - Don't try to move .eh_frame in case it's not necessary.

https://reviewboard.mozilla.org/r/261154/#review268226

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bfba6f64e7b
Don't try to move .eh_frame in case it's not necessary. r=froydnj

Comment 4

[Andreea Pavel [:apavel]]

Backed out for android build bustages

Push that caused the failrues: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6bfba6f64e7bf6548a4f03146b14a47c48b56791

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191950324&repo=autoland&lineNumber=34218

Backout: https://hg.mozilla.org/integration/autoland/rev/3b34dfce3ce4acdca4a0e906b8c8373b4d868874

Comment 5

[Mike Hommey [:glandium]]

Huh, on android, eh_frame appears before eh_frame_hdr.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8997345 [details]
Bug 1480688 - Don't try to move .eh_frame in case it's not necessary.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/261154/diff/1-2/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8997345 [details]
Bug 1480688 - Don't try to move .eh_frame in case it's not necessary.

There are enough changes that this requires another review.

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8997345 [details]
Bug 1480688 - Don't try to move .eh_frame in case it's not necessary.

https://reviewboard.mozilla.org/r/261154/#review268860

One wonders if somebody made the decision to put `.eh_frame` before `.eh_frame_hdr` on some targets just because.

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 8997345 [details]
Bug 1480688 - Don't try to move .eh_frame in case it's not necessary.

https://reviewboard.mozilla.org/r/261154/#review268860

It could be a linker thing. It's before on android x86, and it's linked with gold. It's after on non-android linux, and it's linked with ld.bfd.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77bb267e83a4
Don't try to move .eh_frame in case it's not necessary. r=froydnj

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/77bb267e83a4