Closed Bug 1480695 Opened 7 years ago Closed 7 years ago

Add telemetry to determine usage of filters on OOP iframes

Categories

(Core :: Web Painting, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Fission Milestone M4
Tracking Status
firefox63 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(2 files)

In order to determine what we should do to support filters on OOP iframes, we should first figure out how frequently they occur.
Attachment #8997366 - Flags: review?(francois)
Attachment #8997367 - Flags: review?(nfroyd)
Comment on attachment 8997367 [details] [diff] [review] Add a usage counter to record when we get a cross-origin iframe within a CSS/SVG filter. Review of attachment 8997367 [details] [diff] [review]: ----------------------------------------------------------------- I think you want a DOM-ish person reviewing this instead of me?
Attachment #8997367 - Flags: review?(nfroyd) → review?(kyle)
Comment on attachment 8997366 [details] oop-iframe-filter-data-review.md 1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate? Yes, in this bug. 2) Is there a control mechanism that allows the user to turn the data collection on and off? Yes, telemetry setting. 3) If the request is for permanent data collection, is there someone who will monitor the data over time?** Yes, Matt Woodrow. 4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under? ** Category 1. 5) Is the data collection request for default-on or default-off? Deafault ON, all channels. 6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? No. 7) Is the data collection covered by the existing Firefox privacy notice? Yes. 8) Does there need to be a check-in in the future to determine whether to renew the data? No, permanent.
Attachment #8997366 - Flags: review?(francois) → review+
Comment on attachment 8997367 [details] [diff] [review] Add a usage counter to record when we get a cross-origin iframe within a CSS/SVG filter. Review of attachment 8997367 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsSubDocumentFrame.cpp @@ +382,5 @@ > + if (aBuilder->IsInFilter()) { > + nsIDocument* outerDoc = PresShell()->GetDocument(); > + nsIDocument* innerDoc = presShell->GetDocument(); > + if (outerDoc && innerDoc) { > + if (outerDoc->NodePrincipal() != innerDoc->NodePrincipal()) { I don't know enough to say whether this check is the right check, I'm leaving this for qdot to review. ::: layout/painting/nsDisplayList.h @@ +1173,5 @@ > > /** > * A helper class to temporarily set the value of mFilterASR. > */ > class AutoFilterASRSetter { Let's rename this to AutoEnterFilter or something like that, and mention that it controls both mFilterASR and mInFilter.
Attachment #8997367 - Flags: review?(mstange) → review+
Comment on attachment 8997367 [details] [diff] [review] Add a usage counter to record when we get a cross-origin iframe within a CSS/SVG filter. Review of attachment 8997367 [details] [diff] [review]: ----------------------------------------------------------------- Ok, while this check looks correct to me, I'm not super familiar with how OOP iframes currently work (still getting up to speed there). Forwarding review to Nika, who I believe worked on OOP iframes as they are right now.
Attachment #8997367 - Flags: review?(kyle) → review?(nika)
Comment on attachment 8997367 [details] [diff] [review] Add a usage counter to record when we get a cross-origin iframe within a CSS/SVG filter. Review of attachment 8997367 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/UseCounters.conf @@ +124,5 @@ > // document.open information > custom DocumentOpen calls document.open in a way that creates a new Window object > custom DocumentOpenReplace calls document.open in a way that creates a new Window object and replaces the old history entry. > + > +custom FilteredCrossOriginIFrame cross-origin <iframe> within a CSS/SVG filter If you change this to be based on site, please also update this to say 'cross-site <iframe>' ::: layout/generic/nsSubDocumentFrame.cpp @@ +382,5 @@ > + if (aBuilder->IsInFilter()) { > + nsIDocument* outerDoc = PresShell()->GetDocument(); > + nsIDocument* innerDoc = presShell->GetDocument(); > + if (outerDoc && innerDoc) { > + if (outerDoc->NodePrincipal() != innerDoc->NodePrincipal()) { This isn't the correct check to do here. You want to use 'nsIPrincipal::Equals' here to handle principal comparisons correctly. Pointer equality will almost always fail here. e.g. `outerDoc->NodePrincipal()->Equals(innerDoc->NodePrincipal())` This is also ~technically~ more strict than what we would need for Fission, which is only restricting based on same-site. If you want to compare based on that, you can compare the two documents' 'DocGroup's by identity. I think doing it based on same-origin is probably the cleanest option, however.
Attachment #8997367 - Flags: review?(nika) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a18c257cf35d Add telemetry to record how frequently we encounter a cross-origin <iframe> within a filter. r=mstange,Nika
Backed out changeset a18c257cf35d (bug 1480695) for build bustage at build/src/obj-firefox/dist/include/nsDisplayList.h Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/d448684096cd16f67fcc842f43e2111aeb56332b Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a18c257cf35d1b10cd713579b83357084812ba72 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=192921639&repo=mozilla-inbound&lineNumber=17799 task 2018-08-09T04:44:44.998Z] 04:44:44 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_image0.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/obj-firefox/image -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/image/decoders -I/builds/worker/workspace/build/src/layout/svg -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/xpcom/threads -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -Wno-error=shadow -MD -MP -MF .deps/Unified_cpp_image0.o.pp /builds/worker/workspace/build/src/obj-firefox/image/Unified_cpp_image0.cpp [task 2018-08-09T04:44:44.999Z] 04:44:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/image' [task 2018-08-09T04:44:45.000Z] 04:44:44 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/image' [task 2018-08-09T04:44:45.000Z] 04:44:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/image' [task 2018-08-09T04:44:45.015Z] 04:44:45 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/image' [task 2018-08-09T04:44:45.015Z] 04:44:45 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/image' [task 2018-08-09T04:44:45.844Z] 04:44:45 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:45.845Z] 04:44:45 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o GrGLGpuCommandBuffer.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DSKIA_IMPLEMENTATION=1 -DSK_PDF_USE_SFNTLY=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/obj-firefox/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/c -I/builds/worker/workspace/build/src/gfx/skia/skia/include/codec -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/effects -I/builds/worker/workspace/build/src/gfx/skia/skia/include/encode -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/pathops -I/builds/worker/workspace/build/src/gfx/skia/skia/include/ports -I/builds/worker/workspace/build/src/gfx/skia/skia/include/private -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils/mac -I/builds/worker/workspace/build/src/gfx/skia/skia/include/views -I/builds/worker/workspace/build/src/gfx/skia/skia/src/core -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/effects -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/gl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/glsl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/image -I/builds/worker/workspace/build/src/gfx/skia/skia/src/lazy -I/builds/worker/workspace/build/src/gfx/skia/skia/src/opts -I/builds/worker/workspace/build/src/gfx/skia/skia/src/sfnt -I/builds/worker/workspace/build/src/gfx/skia/skia/src/shaders -I/builds/worker/workspace/build/src/gfx/skia/skia/src/sksl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils/mac -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils/win -I/builds/worker/workspace/build/src/gfx/sfntly/cpp/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Wno-deprecated-declarations -Wno-overloaded-virtual -Wno-shadow -Wno-sign-compare -Wno-unreachable-code -Wno-unused-function -Wno-implicit-fallthrough -Wno-inconsistent-missing-override -Wno-macro-redefined -Wno-unused-private-field -MD -MP -MF .deps/GrGLGpuCommandBuffer.o.pp /builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/gl/GrGLGpuCommandBuffer.cpp [task 2018-08-09T04:44:45.845Z] 04:44:45 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:45.846Z] 04:44:45 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:45.846Z] 04:44:45 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:45.874Z] 04:44:45 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:45.875Z] 04:44:45 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/layers' [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_gfx_layers0.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DOS_POSIX=1 -DOS_MACOSX=1 -DD3D_DEBUG_INFO -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/layers -I/builds/worker/workspace/build/src/obj-firefox/gfx/layers -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/media/libyuv/libyuv/include -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -Wno-error=shadow -Wno-maybe-uninitialized -MD -MP -MF .deps/Unified_cpp_gfx_layers0.o.pp /builds/worker/workspace/build/src/obj-firefox/gfx/layers/Unified_cpp_gfx_layers0.cpp [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/gfx/layers/Unified_cpp_gfx_layers0.cpp:2: [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - In file included from /builds/worker/workspace/build/src/gfx/layers/AnimationHelper.cpp:18: [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/nsDisplayList.h:1200:10: error: private field 'mOldInFilter' is not used [-Werror,-Wunused-private-field] [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - bool mOldInFilter; [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - ^ [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - 1 error generated. [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - /builds/worker/workspace/build/src/config/rules.mk:1086: recipe for target 'Unified_cpp_gfx_layers0.o' failed [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - make[4]: *** [Unified_cpp_gfx_layers0.o] Error 1 [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/layers' [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - make[4]: *** Waiting for unfinished jobs.... [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.507Z] 04:44:53 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.510Z] 04:44:53 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.511Z] 04:44:53 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/animation' [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_dom_animation0.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/animation -I/builds/worker/workspace/build/src/obj-firefox/dom/animation -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -MD -MP -MF .deps/Unified_cpp_dom_animation0.o.pp /builds/worker/workspace/build/src/obj-firefox/dom/animation/Unified_cpp_dom_animation0.cpp [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dom/animation/Unified_cpp_dom_animation0.cpp:83: [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - In file included from /builds/worker/workspace/build/src/dom/animation/EffectCompositor.cpp:22: [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/LayerAnimationInfo.h:12: [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/nsDisplayList.h:1200:10: error: private field 'mOldInFilter' is not used [-Werror,-Wunused-private-field] [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - bool mOldInFilter; [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - ^ [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - 1 error generated. [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - /builds/worker/workspace/build/src/config/rules.mk:1086: recipe for target 'Unified_cpp_dom_animation0.o' failed [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - make[4]: *** [Unified_cpp_dom_animation0.o] Error 1 [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/animation' [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/animation/target' failed [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - make[3]: *** [dom/animation/target] Error 2 [task 2018-08-09T04:44:53.858Z] 04:44:53 INFO - make[3]: *** Waiting for unfinished jobs.... [task 2018-08-09T04:44:53.861Z] 04:44:53 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.861Z] 04:44:53 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.883Z] 04:44:53 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:53.885Z] 04:44:53 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia' [task 2018-08-09T04:44:54.248Z] 04:44:54 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest' [task 2018-08-09T04:44:54.252Z] 04:44:54 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_gfx_tests_gtest0.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/gfx/2d -I/builds/worker/workspace/build/src/gfx/2d/unittest -I/builds/worker/workspace/build/src/gfx/config -I/builds/worker/workspace/build/src/gfx/layers -I/builds/worker/workspace/build/src/gfx/ots/src -I/builds/worker/workspace/build/src/gfx/qcms -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -Wno-error=shadow -MD -MP -MF .deps/Unified_cpp_gfx_tests_gtest0.o.pp /builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest/Unified_cpp_gfx_tests_gtest0.cpp [task 2018-08-09T04:44:54.253Z] 04:44:54 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest' [task 2018-08-09T04:44:54.254Z] 04:44:54 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest' [task 2018-08-09T04:44:54.254Z] 04:44:54 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest' [task 2018-08-09T04:44:54.255Z] 04:44:54 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest' [task 2018-08-09T04:44:54.255Z] 04:44:54 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/tests/gtest' [task 2018-08-09T04:44:54.486Z] 04:44:54 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
Flags: needinfo?(matt.woodrow)
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a45929e06aa9 Add telemetry to record how frequently we encounter a cross-origin <iframe> within a filter. r=mstange,Nika
Flags: needinfo?(matt.woodrow)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: