1480719 - Credit card form can be saved without expiration date (payment will not be processed)

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

[Affected versions]:
Nightly 63.0a1

[Affected platforms]:
Windows 10 x64, Ubuntu 16.04, Mac OS 10.13

[Prerequisites]:
- set the pref dom.payments.request.enabled to "true"
- have a profile with saved cards

[Steps to reproduce]:
1. Go to “https://rsolomakhin.github.io/pr/single/” and click on “Buy” button
2. Select a saved shipping address
3. Click on “Add” link for a new Credit Card
4. Fill all the field with valid data, except expiration date
5. Click on “Add” button
6. Type in the CVV code and click on “Pay”

[Expected Result]:
The “Add” button from the Add Credit Card screen should be grayed out if the expiration date is missing.

[Actual Result]:
The Credit Card is saved without the expiration date. However, the “Pay” button is not functional. Check: https://streamable.com/v6wyo

Comment 1

[Matthew N. [:MattN]]

Reminder to add the asterisk to the field(s) when making it required.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1480719 - Require credit card expiration month and year before saving credit cards. r?MattN

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 9004681 [details]
Bug 1480719 - Require credit card expiration month and year before saving credit cards. r?MattN

Matthew N. [:MattN] (PM if requests are blocking you) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee00cb44157b
Require credit card expiration month and year before saving credit cards. r=MattN

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ee00cb44157b

Comment 6

[Timea Cernea [:tbabos][inactive]]

Verified fixed on the latest Firefox Nightly version on Windows 10, Ubuntu 16.04 and MacOS 10.13.
The expiration date, month and year, are mandatory fields to fill in order to save or edit the credit card.