1480771 - Unable to run xpcshell tests with tup build backend enabled

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Trying to run xpcshell tests with the tup build backend enabled, I
get an error saying the CLOBBER file has been updated:

> % ./mach xpcshell-test --sequential testing/marionette/test/unit/test_sync.js
> 
> The build system was unable to install tests because the CLOBBER file
> has been updated. This means if you edited any test files, your
> changes may not be picked up until a full/clobber build is performed.
> 
> The easiest and fastest way to perform a clobber build is to run:
> 
>  $ mach clobber
>  $ mach build
> 
> If you did not modify any test files, it is safe to ignore this
> message and proceed with running tests. To do this run:
> 
>  $ touch /home/ato/src/gecko/obj-x86_64-pc-linux-gnu/CLOBBER

Comment 1

[Chris Manchester (limited bugmail, email directly)]

This is related to bug 1478798. This should work with the proposed patch there and an additional provision to re-run configure when CLOBBER changes, which we should probably be doing anyway.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

In the meantime, touching CLOBBER before proceeding is probably safe.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1480771 - Take CLOBBER into account when deciding whether to re-run configure.

Comment 4

[Phabricator Automation]

Comment on attachment 8998024 [details]
Bug 1480771 - Take CLOBBER into account when deciding whether to re-run configure.

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D2802

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/536829999219
Take CLOBBER into account when deciding whether to re-run configure. r=gps,firefox-build-system-reviewers

Comment 6

[Chris Manchester (limited bugmail, email directly)]

To give some more context to this fix: bug 1478798 along with this change should keep the clobber file from getting in peoples way at all when building with tup, but in the meantime this change means ./mach build followed by running tests will no longer cause this problem, ./mach build will instead manage and keep the clobber file up to date.

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/536829999219