1480774 - Merge pushlog-legacy into pushlog

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, enhancement)

Description

[Connor Sheehan [:sheehan]]

We currently have two "pushlog" extensions living in version-control-tools: `pushlog` and `pushlog-legacy`. `pushlog-legacy` currently holds the code related to generating pushlog feeds, and `pushlog` holds the bulk of the extension code (wire protocol extensions, database interactions, etc). We should move `pushlog-legacy` into the `pushlog` extension so we have a single source of truth for this crucial feature.

Additionally, we could clean up the code in `pushlog-legacy` and have the feeds make better use of Mercurial's template layer. For now, let's get the functionality moved under one roof.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: pushlog: merge `pushlog-feed` into `pushlog` (Bug 1480774) r?gps

This commit merges `pushlog-legacy` into `pushlog`. The `pushlog-feed.py`
file is renamed to simply `feed.py`, and `test-hgweb.t` in
`pushlog-legacy` is renamed to `test-hgweb-feed.t`. Most other
changes required a simple path change, such as the new feed extension
path and the new location of the `helpers.sh` test macros. We also
update the docs to reference the new extension locations.

There is still some work to be done merging the two extensions into
one, so we don't need to specify both `pushlog-feed` and `pushlog`
in hgrc files. We will iterate on this in the future - having a
single home for pushlog is the goal of this commit.

Comment 2

[Phabricator Automation]

Comment on attachment 8997444 [details]
pushlog: merge `pushlog-feed` into `pushlog` (Bug 1480774) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D2726

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/73e0bf282bfb
pushlog: merge `pushlog-feed` into `pushlog` r=gps