148078 - Context menu of message window contains wrong items

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Eugen Dedu]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0rc3) Gecko/20020529
Debian/1.0rc3-1
BuildID:    1.0RC3

The context menu (mouse right-click) on message window (double-clik on a message
summary in Mail window) contains wrong items.  For example, for a pure text
e-mail, it shows:
- copy link location
- copy image location
- copy email address
- save link target as...
- save image as...
- bookmark this link
Neither of these items work and they should not be present here.
The Label item contains only grayed subitems.
Also, there are two consecutive horizontal lines in this menu.

Reproducible: Always
Steps to Reproduce:
1. Open the Mail/News window
2. Double-click on a message summary (or choose Open message in new window in
its context menu)
3. Open the context menu (right-click) on the new window (the message window).

Expected Results:  Remove the wrong items from the context menu.

I use modern theme.

Comment 1

[Andreas Kunz]

I can confirm this also in classic skin with 2002051006.

Comment 2

[R.K.Aa.]

Attachment: screenshots from current trunk, Linux

Comment 3

[scottputterman]

Does this happen in a current branch build?  My understanding is that
http://bugzilla.mozilla.org/show_bug.cgi?id=138826 which may have fixed this
wasn't checked in until after RC3.

Comment 4

[scottputterman]

I meant to say that the patch which may fix this is only checked into the trunk.

Comment 5

[(not reading, please use [e-mail] instead)]

*** Bug 148561 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

this is a regresion, caused by bug #138018

Comment 7

[(not reading, please use [e-mail] instead)]

accepting, patch on the way...

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: the fix.

Comment 9

[(not reading, please use [e-mail] instead)]

fixed on trunk.  this has r/sr=bienvenu.  this fix is not needed on the 1.0 
branch, unless #138018 lands on the 1.0 branch.

Comment 10

[R.K.Aa.]

Something is still funny with a fresh trunk CVS build, Linux:

The first item you click get two extra dividers. Next click - regardless of
"link type" - gets only one extra divider.

Seeing this in both in three-pane and standalone msg window

Comment 11

[(not reading, please use [e-mail] instead)]

R.K.A, can you provide a screen shot of the problem in bug 
http://bugzilla.mozilla.org/show_bug.cgi?id=137141?

more context menu work is going on in http://bugzilla.mozilla.org/show_bug.cgi?
id=137141, and ssu / neil might be working on this issue there.

Comment 12

[Sean Su]

yep... the patch to bug 137141 will definitely fix this problem.

Comment 13

[R.K.Aa.]

Attachment: screenshot

As a rule:

The first right-click after mailnews or standalone is opened,
will show an extra separator. Exeptions: 1 and 6

1,2,3,4,5: Same in 3-pane and standalone:

1 and 5: right-click on mail link:
First and second right-click on a mail link:
First click shows an extra separator also on TOP
The extra separator at bottom remains after a second click

-------------------------------------------------

2: right-click web-link
3: right-click selected text (3-pane)
4: 4: right-click empty area

First click shows an extra separator.
Next click shows correct number/location of separators.

-------------------------------------------------

6: Standalone msg window: SPECIAL CASE
This window behaves like 3-pane what separators are concerned,
*apart from when text is selected*.

If the first thing I do is select text, and then right-click:
No extra separator, but an awful lot of extra menu-items.
Other context menus in standalone may go crazy after this, and show wrong
menus.
When i select and right-click JS console initially complains:

On right downclick when text selected in standalone:

Error: searchSelect has no properties
Source File: chrome://communicator/content/nsContextMenu.js
Line: 707

On the following left-click:
Error: gContextMenu has no properties

Similarly: when first right-click a link in standalone, and then select some
plain text and right-click that:
It will show the context menu of the link, not the selection.

Comment 14

[[e-mail]]

The patch in 137141 will also fix the selected text problem, that fix might
still need to go on the trunk.

Comment 15

[Sean Su]

it might... I'm hoping my merging foo is strong.

Comment 16

[Olga]

Verified on branch 06/12/02, Win2K (classic), Linux (modern), Mac OSX (modern).
No extra separators in Stand Alone message.