Closed
Bug 1480910
Opened 6 years ago
Closed 6 years ago
Spinbuttons in reminder not showing the correct arrows
Categories
(Calendar :: Alarms, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
6.2.2.1
People
(Reporter: jorgk-bmo, Assigned: Paenglab)
Details
Attachments
(2 files)
|
4.83 KB,
image/png
|
Details | |
|
1.50 KB,
patch
|
MakeMyDay
:
review+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
2018-08-03 23_43_23-.png
See attachment. That's with TB 60 ESR with the latest uplifts.
|
Reporter | |
Updated•6 years ago
|
Summary: Spinbuttons in reminder not showing the correct icon → Spinbuttons in reminder not showing the correct arrows
|
Assignee | |
Comment 1•6 years ago
|
||
TB 63 doesn't need this link to spinbuttons.css because m-c changed how toolkit files are loaded and so it wasn't detected. TB 60 needs this file to override buttons.css. spinbuttons.css is loaded by bindings.css but this isn't enough to override buttons.css because buttons.css is loaded after spinbuttons.css then.
Attachment #8997609 -
Flags: review?(makemyday)
Attachment #8997609 -
Flags: approval-calendar-esr?(philipp)
Attachment #8997609 -
Flags: approval-calendar-beta?(philipp)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8997609 [details] [diff] [review] spinbuttons-link.patch Review of attachment 8997609 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. This is just needed for esr, right?
Attachment #8997609 -
Flags: review?(makemyday) → review+
|
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to [:MakeMyDay] from comment #2) > Thanks. This is just needed for esr, right? Well, chrome://global/skin/spinbuttons.css doesn't exist in trunk, so we might as well fix it there, too, no?
|
|
Assignee | |
Comment 4•6 years ago
|
||
The link in c-c is broken too and needs to be fixed. But we could it remove it later.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/ed630428eed9 Point to the correct spinbuttons.css in alarm dialog. r=MakeMyDay DONTBUILD
|
|
Reporter | |
Updated•6 years ago
|
Target Milestone: --- → 6.5
|
||
Comment 6•6 years ago
|
||
Comment on attachment 8997609 [details] [diff] [review] spinbuttons-link.patch Review of attachment 8997609 [details] [diff] [review]: ----------------------------------------------------------------- I'm approving both, feel free to remove beta approval if necessary.
Attachment #8997609 -
Flags: approval-calendar-esr?(philipp)
Attachment #8997609 -
Flags: approval-calendar-esr+
Attachment #8997609 -
Flags: approval-calendar-beta?(philipp)
Attachment #8997609 -
Flags: approval-calendar-beta+
|
|
Reporter | |
Comment 7•6 years ago
|
||
TB 60 ESR, Cal 6.2: https://hg.mozilla.org/releases/comm-esr60/rev/6a81c75e85deb12d2d3a39efb07b81cb6eef919d
Target Milestone: 6.5 → 6.2
Version: Trunk → Lightning 6.2
|
|
Reporter | |
Updated•6 years ago
|
Attachment #8997609 -
Flags: approval-calendar-beta+
|
|
||
Updated•6 years ago
|
Target Milestone: 6.2 → 6.2.1
|
|
Reporter | |
Updated•6 years ago
|
Target Milestone: 6.2.1 → 6.2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•