Closed Bug 1480911 Opened 6 years ago Closed 6 years ago

mozharness fails when run locally on Windows when environment contains unicode strings

Categories

(Release Engineering :: Applications: MozharnessCore, enhancement)

Product:
Release Engineering
Component:
Applications: MozharnessCore
Platform:
Unspecified
Windows
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 fixed, firefox63 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Encode any env vars containing unicode on Windows
1.80 KB, patch
mozilla
: review+
Details | Diff | Splinter Review
Apparently something in my path is being interpreted by python 2 as unicode, so creating child processes fails unless we clean that up.
Comment on attachment 8998254 [details] [diff] [review] Encode any env vars containing unicode on Windows This looks like it could work. Have you tested it?
Yes. I could not run Talos locally before, but now I can.
Attachment #8998254 - Flags: review?(aki) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1c25fdedf62d20563fdd48fd39873f9625a5d8 Bug 1480911: Fix mozharness to handle unicode environment variables when run locally on Windows; r=aki
https://hg.mozilla.org/mozilla-central/rev/8a1c25fdedf6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: