1480913 - Convert 'extra_args' entry in browser config from string to list

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

I've got some additional parameters that will eventually need to be passed to the browser.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: convert extra_args from str to list of str

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: convert extra_args from str to list of str (r2)

Whoops, something snuck into that previous patch. This is the correct one.

Comment 3

[Robert Wood [:rwood]]

Comment on attachment 8998251 [details] [diff] [review]
convert extra_args from str to list of str (r2)

Review of attachment 8998251 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, one nit: missed the initial extra_args value (please change this to an empty list):

https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/testing/talos/talos/config.py#22

I see that there's already support for using a list type instead of string for extra args (link below) so this should be seamless.

https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/testing/talos/talos/utils.py#127

Please fix the nit and push to try running the entire talos suite on at least Win10 and Linux64. Please attach try link to this bug. Thanks!

r+ on nit and green try

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9835f1980d20cf497a69f3eb7fd2c860cbd1441

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c9aef1dbc3ded62e553753d694905b7c1f34d48
Bug 1480913: Convert extra_args field in talos firefox setup from a str to a list; r=rwood

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7c9aef1dbc3d