1480982 - CustomizeMode.jsm: replace _dwu getter with _getBoundsWithoutFlushing method

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P3)

Description

[Dão Gottwald [:dao]]

In CustomizeMode.jsm, every place where _dwu is used ends up calling getBoundsWithoutFlushing:

  foo = this._dwu.getBoundsWithoutFlushing(...);

So let's replace this:

https://searchfox.org/mozilla-central/source/browser/components/customizableui/CustomizeMode.jsm#1648-1654

with a new getBoundsWithoutFlushing method:

  getBoundsWithoutFlushing(element) {
    return this.window.windowUtils.getBoundsWithoutFlushing(element);
  },

and replace the _dwu users with a call to our new method:

  foo = this.getBoundsWithoutFlushing(...);

Comment 1

[Dão Gottwald [:dao]]

Small correction: let's prefix "getBoundsWithoutFlushing" with "_".

So:

  _getBoundsWithoutFlushing(element) {
    return this.window.windowUtils.getBoundsWithoutFlushing(element);
  },

--

  foo = this._getBoundsWithoutFlushing(...);

Comment 2

[Thi Huynh]

Attachment: Bug 1480982 - Replace _dwu getter with _getBoundsWithoutFlushing method in CustomizeMode.jsm.

Review commit: https://reviewboard.mozilla.org/r/261428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261428/

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8997705 [details]
Bug 1480982 - Replace _dwu getter with _getBoundsWithoutFlushing method in CustomizeMode.jsm.

https://reviewboard.mozilla.org/r/261428/#review268462

Nice, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6f7f73cf5d8
Replace _dwu getter with _getBoundsWithoutFlushing method in CustomizeMode.jsm. r=dao

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d6f7f73cf5d8