Closed Bug 1480992 Opened Last year Closed Last year

Perma-failing OS X Cross Compiled bustages at dom/ipc/ContentChild.cpp when gecko 63 merges to Beta on 2018-08-27

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla63
Tracking Status
thunderbird_esr52 --- unaffected
thunderbird_esr60 --- unaffected
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- verified

People

(Reporter: apavel, Assigned: Alex_Gaynor)

References

Details

Attachments

(2 files)

Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Flags: needinfo?(agaynor)
Comment on attachment 8997681 [details]
Bug 1480992 - move function call into diagnostic assert to prevent complains about variable not used in release opt builds.

https://reviewboard.mozilla.org/r/261380/#review268536

::: dom/ipc/ContentChild.cpp:1643
(Diff revision 1)
>      // future connections as well. We do this for sandboxing, but it also ensures
>      // that the Activity Monitor will not label the content process as "Not
>      // responding" because it's not running a native event loop. See bug 1384336.
>      CGSShutdownServerConnections();
> -    CGError result = CGSSetDenyWindowServerConnections(true);
> -    MOZ_DIAGNOSTIC_ASSERT(result == kCGErrorSuccess);
> +    MOZ_DIAGNOSTIC_ASSERT(
> +      CGSSetDenyWindowServerConnections(true) == kCGErrorSuccess

CGSSetDenyWindowServerConnections is side-effecting (“set” is a verb; see also bug 1384336 comment #20), and this will remove the call on beta/release, which is not what we want.
Comment on attachment 8997681 [details]
Bug 1480992 - move function call into diagnostic assert to prevent complains about variable not used in release opt builds.

https://reviewboard.mozilla.org/r/261380/#review268742

r- for the reason :jld said, I'll upload a different patch.
Attachment #8997681 - Flags: review?(agaynor) → review-
Assignee: aryx.bugmail → agaynor
Comment on attachment 8998207 [details]
Bug 1480992 - fixed perma-fail compilation warning on beta builds; r?haik

Haik Aftandilian [:haik] has approved the revision.
Attachment #8998207 - Flags: review+
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/764bcd0ac036
fixed perma-fail compilation warning on beta builds; r=haik
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/764bcd0ac036
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.