Closed
Bug 1481025
Opened 8 years ago
Closed 8 years ago
Devtools code attempts to call message manager methods with a null target
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
There are a several places where devtools code destructures message manager methods and calls them without a `this` object. This currently works, because child message managers are currently global objects, and treat those calls as targeted to the global.
That will change in bug 1480244, though, and is not exactly a good practice even now.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8997683 [details]
Bug 1481025: Fix devtools code which calls message manager methods with a null target.
https://reviewboard.mozilla.org/r/261388/#review269070
Sure. Looks good to me!
Attachment #8997683 -
Flags: review?(poirot.alex) → review+
|
||
Updated•8 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc96a72ae14f9dcd9ba0245cc6f8f9a6dcb6e81
Bug 1481025: Fix devtools code which calls message manager methods with a null target. r=ochameau
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•