Closed Bug 1481116 Opened 6 years ago Closed 6 years ago

New SMS reminder icon required

Categories

(Calendar :: Provider: GData, enhancement)

Product:
Calendar
Component:
Provider: GData
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
6.2.2.1

People

(Reporter: darktrojan, Assigned: Paenglab)

References

Details

Attachments

(1 file)

GData-SMS-icon.patch
3.35 KB, patch
darktrojan
: review+
Fallen
: approval-calendar-esr+
Details | Diff | Splinter Review 
calendar/providers/gdata/content/reminder-action-sms.png

Two reasons:
* the icon doesn't match the other alarm icon now that it's changed
* if we replace it we don't need to acknowledge the famfamfam icons any more
Attached patch GData-SMS-icon.patch — — Splinter Review 
Something like this? This is an icon from FX.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8997793 - Flags: review?(geoff)
Comment on attachment 8997793 [details] [diff] [review]
GData-SMS-icon.patch

Review of attachment 8997793 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect! Ship it.
Attachment #8997793 - Flags: review?(geoff) → review+
Keywords: checkin-needed
Attachment #8997793 - Flags: approval-calendar-esr?(philipp)
Attachment #8997793 - Flags: approval-calendar-beta?(philipp)
Attachment #8997793 - Flags: approval-calendar-esr?(philipp)
Attachment #8997793 - Flags: approval-calendar-esr+
Attachment #8997793 - Flags: approval-calendar-beta?(philipp)
Attachment #8997793 - Flags: approval-calendar-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/79172df2e498
Use a SVG icon for the SMS reminder. r=darktrojan
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
Attachment #8997793 - Flags: approval-calendar-beta+
Target Milestone: 6.2 → 6.2.1
Target Milestone: 6.2.1 → 6.2.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: