1481145 - [GLX] Remove GLX visual selection hack for ATI/fglrx

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

A follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1478454#c39

We removed the GLX Visual selection hack for NVIDIA drivers and I think we should also do so for ATI cards. The hack was introduced at Bug 572939 for fglrx drivers which are no longer used by modern ATI/AMD cards and the hack may cause BadMatch X error.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1481145 - [GLX] Remove GLX visual selection hack for ATI/fglrx,

There's a hack for ATI/fglrx drivers where a newly created glxContext uses a different glx visual
than the associated X drawable due to bug at ATI/fglrx (Bug 572939).

This hack may cause X11 BadMatch error when we make the created glxContext current
as GLX requies identical visual at X drawable and glxContext.

Also ATI/fglrx isn't used by modern gfx hardware so let's remove the hack
and get glxContext directly from X drawable.

Review commit: https://reviewboard.mozilla.org/r/261526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261526/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8997807 [details]
Bug 1481145 - [GLX] Remove GLX visual selection hack for ATI/fglrx,

https://reviewboard.mozilla.org/r/261526/#review268582

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Merged with patch from Bug 1478454.