Closed
Bug 1481154
Opened 6 years ago
Closed 6 years ago
Minor bugs in GData provider
Categories
(Calendar :: Provider: GData, enhancement)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
FIXED
6.2.2.1
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
|
2.52 KB,
patch
|
MakeMyDay
:
review+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Should be self-explanatory, but just in case: * We're loading a file that's been renamed. * A monkey patch isn't calling the patched function with the right arguments. This one breaks mozmill tests for local builds.
Attachment #8997802 -
Flags: review?(philipp)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8997802 -
Flags: review?(philipp) → review?(makemyday)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8997802 [details] [diff] [review] 1481154-gdata-nits-1.diff Review of attachment 8997802 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/providers/gdata/content/gdata-lightning-item-iframe.js @@ +173,5 @@ > > // remember the selected index > gLastAlarmSelection = reminderList.selectedIndex; > } else { > + rv = protofunc.call(this, reminders, ...args); loadReminders could have just one argument - the reminders array, so one could spare the ...args here. But I'm also fine with leaving it as is.
Attachment #8997802 -
Flags: review?(makemyday) → review+
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8997802 [details] [diff] [review] 1481154-gdata-nits-1.diff Philipp, do we need this for 6.2 as well?
Attachment #8997802 -
Flags: approval-calendar-esr?(philipp)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Updated•6 years ago
|
Attachment #8997802 -
Flags: approval-calendar-esr?(philipp) → approval-calendar-esr+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/a9a60798fc90 Fix two minor bugs in GData provider. r=MakeMyDay
|
||
Updated•6 years ago
|
Target Milestone: --- → 6.5
|
|
||
Comment 5•6 years ago
|
||
TB 60 beta 11 / Cal 6.2: https://hg.mozilla.org/releases/comm-beta/rev/c688ef1e57ef4fa9ce6b81a33a151b7d408119a3
Target Milestone: 6.5 → 6.2
|
|
||
Comment 6•6 years ago
|
||
TB 60.1 ESR / Cal 6.2.1: https://hg.mozilla.org/releases/comm-esr60/rev/020f8c9a20b4221fd8928c55e096be786542c5dd
|
|
||
Updated•6 years ago
|
Target Milestone: 6.2 → 6.2.1
|
|
||
Updated•6 years ago
|
Target Milestone: 6.2.1 → 6.2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•