1481154 - Minor bugs in GData provider

Status: RESOLVED FIXED

(Calendar :: Provider: GData, enhancement)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1481154-gdata-nits-1.diff

Should be self-explanatory, but just in case:

* We're loading a file that's been renamed.
* A monkey patch isn't calling the patched function with the right arguments. This one breaks mozmill tests for local builds.

Comment 2

[[:MakeMyDay]]

Comment on attachment 8997802 [details] [diff] [review]
1481154-gdata-nits-1.diff

Review of attachment 8997802 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/providers/gdata/content/gdata-lightning-item-iframe.js
@@ +173,5 @@
>  
>              // remember the selected index
>              gLastAlarmSelection = reminderList.selectedIndex;
>          } else {
> +            rv = protofunc.call(this, reminders, ...args);

loadReminders could have just one argument - the reminders array, so one could spare the ...args here. But I'm also fine with leaving it as is.

Comment 3

[[:MakeMyDay]]

Comment on attachment 8997802 [details] [diff] [review]
1481154-gdata-nits-1.diff

Philipp, do we need this for 6.2 as well?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a9a60798fc90
Fix two minor bugs in GData provider. r=MakeMyDay

Comment 5

[Jorg K (CEST = GMT+2)]

TB 60 beta 11 / Cal 6.2:
https://hg.mozilla.org/releases/comm-beta/rev/c688ef1e57ef4fa9ce6b81a33a151b7d408119a3

Comment 6

[Jorg K (CEST = GMT+2)]

TB 60.1 ESR / Cal 6.2.1:
https://hg.mozilla.org/releases/comm-esr60/rev/020f8c9a20b4221fd8928c55e096be786542c5dd