Closed
Bug 1481180
Opened 6 years ago
Closed 5 years ago
TEST-UNEXPECTED-FAIL | comm/calendar/test/unit/test_gdata_provider.js
Categories
(Calendar :: Provider: GData, defect)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 70.0
People
(Reporter: darktrojan, Unassigned)
References
Details
(Whiteboard: [thunderbird-disabled-test])
Attachments
(2 files)
824 bytes,
patch
|
Details | Diff | Splinter Review | |
2.56 KB,
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
On Linux: > TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:comm/calendar/test/unit/test_gdata_provider.js | test_basicItems - [test_basicItems : 923] "undefined" == "20060608T210452Z" I expected to see this, as it happens on my build too. This only happens for icaljs. On OS X: > NS_ERROR_NOT_AVAILABLE: > @/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:33:1 > load_file@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:641:7 > _load_files@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:653:3 > _execute_test@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:507:3 > @-e:1:1 > (xpcshell/head.js) | test MAIN run_test pending (1) > ReferenceError: MockRegistrar is not defined at /Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:71 > replaceAlertsService@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:71:1 > run_test@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:499:5 > _execute_test@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:527:7 > @-e:1:1 I didn't expect to see this. It looks like the test tries to start before the manifest is loaded, because line 33 imports resource://gdata-provider/modules/gdataSession.jsm and this appears before all the warnings about stuff in the manifest. I thought loading the manifest was synchronous.
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(philipp)
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Keywords: leave-open
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/6013dd4ea2e5 temporarily disable test_gdata_provider.js. rs=bustage-fix
Reporter | ||
Updated•6 years ago
|
Whiteboard: [thunderbird-disabled-test]
Comment 3•5 years ago
|
||
Any plans to fix this? We completed the six-month anniversary :-(
Comment 4•5 years ago
|
||
Plans yes, time less so. I'd love to get this running again though. Happy to answer questions about the test if that helps someone else work this out.
Reporter | ||
Comment 5•5 years ago
|
||
I should be able to re-enable this test for libical (which it never broke on), but first the CI needs to be fixed because it broke while we weren't looking.
Updated•5 years ago
|
Flags: needinfo?(philipp)
Reporter | ||
Comment 6•5 years ago
|
||
We can turn this back on for libical only, the CI issue seems to have gone away.
Attachment #9086878 -
Flags: review?(paul)
Comment 7•5 years ago
|
||
Comment on attachment 9086878 [details] [diff] [review] 1481180-enable-gdata-test-1.diff Review of attachment 9086878 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #9086878 -
Flags: review?(paul) → review+
Updated•5 years ago
|
Keywords: leave-open → checkin-needed
Target Milestone: --- → 70
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b9129f265d63
Re-enable test_gdata_provider.js for libical only. r=pmorris
You need to log in
before you can comment on or make changes to this bug.
Description
•