1481180 - TEST-UNEXPECTED-FAIL | comm/calendar/test/unit/test_gdata_provider.js

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Geoff Lankow (:darktrojan)]

On Linux:
> TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:comm/calendar/test/unit/test_gdata_provider.js | test_basicItems - [test_basicItems : 923] "undefined" == "20060608T210452Z"

I expected to see this, as it happens on my build too. This only happens for icaljs.


On OS X:
> NS_ERROR_NOT_AVAILABLE:
> @/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:33:1
> load_file@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:641:7
> _load_files@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:653:3
> _execute_test@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:507:3
> @-e:1:1
> (xpcshell/head.js) | test MAIN run_test pending (1)
> ReferenceError: MockRegistrar is not defined at /Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:71
> replaceAlertsService@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:71:1
> run_test@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/tests/comm/calendar/test/unit/test_gdata_provider.js:499:5
> _execute_test@/Users/cltbld/tasks/task_1533551988/build/tests/xpcshell/head.js:527:7
> @-e:1:1

I didn't expect to see this. It looks like the test tries to start before the manifest is loaded, because line 33 imports resource://gdata-provider/modules/gdataSession.jsm and this appears before all the warnings about stuff in the manifest. I thought loading the manifest was synchronous.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1481180-disable-test.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6013dd4ea2e5
temporarily disable test_gdata_provider.js. rs=bustage-fix

Comment 3

[Jorg K (CEST = GMT+2)]

Any plans to fix this? We completed the six-month anniversary :-(

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Plans yes, time less so. I'd love to get this running again though. Happy to answer questions about the test if that helps someone else work this out.

Comment 5

[Geoff Lankow (:darktrojan)]

I should be able to re-enable this test for libical (which it never broke on), but first the CI needs to be fixed because it broke while we weren't looking.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1481180-enable-gdata-test-1.diff

We can turn this back on for libical only, the CI issue seems to have gone away.

Comment 7

[Paul Morris [:pmorris]]

Comment on attachment 9086878 [details] [diff] [review]
1481180-enable-gdata-test-1.diff

Review of attachment 9086878 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b9129f265d63
Re-enable test_gdata_provider.js for libical only. r=pmorris