Closed
Bug 1481231
Opened 5 years ago
Closed 5 years ago
Add words to the en-US dictionary
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: al11588, Assigned: ananuti)
References
Details
User Story
aluminize, aluminized https://en.oxforddictionaries.com/definition/us/aluminize coupler, couplers https://en.oxforddictionaries.com/definition/us/coupler flaneur - An idler or lounger. https://en.oxforddictionaries.com/definition/us/flaneur infringer - somebody that infringes something. https://en.oxforddictionaries.com/definition/us/infringer retroreflector, retroreflectors - A device which reflects light back along the incident path, irrespective of the angle of incidence. https://en.oxforddictionaries.com/definition/us/retroreflector stealer, stealers https://en.oxforddictionaries.com/definition/us/stealer trailhead, trailheads - The place where a trail begins. https://en.oxforddictionaries.com/definition/us/trailhead yowza (also yowzah, yowsah, yowsa) - Used to express approval, excitement, or enthusiasm. https://en.oxforddictionaries.com/definition/us/yowza
Attachments
(2 files)
|
133.93 KB,
image/png
|
Details | |
|
2.62 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Screenshot_2018-08-06 stealer - Google Search.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0 Build ID: 20180802174131 Steps to reproduce: I right clicked on my sentence and spell check says that "stealer" is not the correct word. Actual results: When I spell checked my sentence I noticed that Firefox says "stealer" is a wrong word and recommends antonyms. Google.com says "stealer" is a real word. Expected results: There should be no red underline on the word "stealer.
|
||
Comment 1•5 years ago
|
||
https://en.oxforddictionaries.com/definition/stealer https://www.dictionary.com/browse/stealer https://www.merriam-webster.com/dictionary/stealer
Blocks: 499593
Component: Untriaged → Spelling checker
OS: Unspecified → All
Product: Firefox → Core
Hardware: Unspecified → All
Summary: Firefox spell checker says that "stealer" is a wrong word. → Add "stealer" to the en-US dictionary
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → ananuti
Status: UNCONFIRMED → NEW
User Story: (updated)
Ever confirmed: true
Summary: Add "stealer" to the en-US dictionary → Add words to the en-US dictionary
Version: 62 Branch → Trunk
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8998064 -
Flags: review?(ehsan)
|
||
Comment 3•5 years ago
|
||
Comment on attachment 8998064 [details] [diff] [review] bug1481231.patch Review of attachment 8998064 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8998064 -
Flags: review?(ehsan) → review+
|
|
||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3398b4fe1bcf Add words to en-US dictionary. r=Ehsan
Keywords: checkin-needed
|
||
Comment 5•5 years ago
|
||
Hi. Ehsan: i landed this but the revision is empty: https://hg.mozilla.org/integration/mozilla-inbound/rev/3398b4fe1bcf27955e0a2e24afc5cfe6afc1f367 Also tried again and i get: mozilla@ubuntu:~/mozilla-unified$ hg qpush applying bug1481231.patch patch bug1481231.patch is empty now at: bug1481231.patch
Flags: needinfo?(ananuti)
|
|
Assignee | |
Comment 6•5 years ago
|
||
I really have no idea. 😕 Download and apply the patch [attachment 8998064 [details] [diff] [review]] work for me. > hg qimp bug1481231.patch > adding bug1481231.patch to series file > hg qpus > applying bug1481231.patch > patching file extensions/spellcheck/locales/en-US/hunspell/en-US.dic > committing files: > extensions/spellcheck/locales/en-US/hunspell/en-US.dic > committing manifest > committing changelog > now at: bug1481231.patch Guessing you get a zero-byte of patch when download or import the patch.
Flags: needinfo?(ananuti)
Keywords: checkin-needed
|
|
||
Comment 7•5 years ago
|
||
Ekanan: i tried again but i get the following: mozilla@ubuntu:~/mozilla-unified$ hg qimport bz://1481231 Fetching... done Parsing...Patch id=8998064 desc="bug1481231.patch" diff data were discarded: UnicodeDecodeError: 'utf8' codec can't decode byte 0xe9 in position 1133: invalid continuation byte done adding 1481231 to series file renamed 1481231 -> bug1481231.patch So far 2 sheriffs tried to land this and could not. Removing the checkin-needed. Aryx: please take a look at the above comments.
|
|
Assignee | |
Comment 8•5 years ago
|
||
> mozilla@ubuntu:~/mozilla-unified$ hg qimport bz://1481231
> Fetching... done
> Parsing...Patch id=8998064 desc="bug1481231.patch" diff data were discarded:
> UnicodeDecodeError: 'utf8' codec can't decode byte 0xe9 in position 1133:
> invalid continuation byte
> done
> adding 1481231 to series file
> renamed 1481231 -> bug1481231.patch
>
> So far 2 sheriffs tried to land this and could not. Removing the
> checkin-needed.
>
> Aryx: please take a look at the above comments.
Uh, i blame it on qimportbz extension.
301 gps.Flags: needinfo?(ananuti) → needinfo?(gps)
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/54fe148fced8 Add words to en-US dictionary. r=Ehsan
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3398b4fe1bcf https://hg.mozilla.org/mozilla-central/rev/54fe148fced8
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
|
||
Updated•5 years ago
|
Flags: needinfo?(aryx.bugmail)
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(gps)
You need to log in
before you can comment on or make changes to this bug.
Description
•