1481251 - Optimize non-A/AAAA type DNS records

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1481251 - Make 2 classes for A/AAAA and By-Type queries.r=mcmanus r=francois

Also add some telemetry.

Comment 2

[François Marier [:francois]]

Comment on attachment 8999155 [details]
Bug 1481251 - Make 2 classes for A/AAAA and By-Type queries.r=mcmanus r=francois

François Marier [:francois] has approved the revision.

Comment 3

[--]

What is a "ByType" ?  If I understand this correctly, this patch separates the HostRecord class in two. One for addresses and one for (other) types. Is that right?

If that's correct, wouldn't "AddrHostRecord" and "TypeHostRecord" (or similar) be more suitable names? The "AAAAAHostRecord" name in particular reads very awkwardly to me.

Comment 4

[Dragana Damjanovic [:dragana]]

(In reply to Daniel Stenberg [:bagder] from comment #3)
> What is a "ByType" ?  If I understand this correctly, this patch separates
> the HostRecord class in two. One for addresses and one for (other) types. Is
> that right?
> 
> If that's correct, wouldn't "AddrHostRecord" and "TypeHostRecord" (or
> similar) be more suitable names? The "AAAAAHostRecord" name in particular
> reads very awkwardly to me.

In bug 1473736  I have added AsyncResolveByType function that queries dns (works only with TRR) for a type that is given as the second parameter of the function. That can be any type like TXT.
AAAAAHostRecord is out original A/AAAA query (this should not have been changed at all)
and byTypeHostRecord is a result of the AsyncResolveByType query and is only an array of strings(not parsed). Currently we only support TXT by-type queries.

I named it AAAAA from A/AAAAA, but you are right AddrHostREcord is better. I will rename it.

(THere may be a bug if we add (in the future) support for A or AAAA by-type query. I will take a look at that and fix it in bug 1473736)

Comment 5

[Dragana Damjanovic [:dragana]]

Attachment: bug_1481251_tele_request.txt

Comment 6

[François Marier [:francois]]

Comment on attachment 9002115 [details]
bug_1481251_tele_request.txt

> 4) Can current instrumentation answer these questions?

I suspect the answer is "no", but please add it to the request.

> 8) If this data collection is default on, what is the opt-out mechanism for users?

There _is_ an opt-out mechanism for users: turning off telemetry.

Comment 7

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1481251 - Optimize non-A/AAAA type DNS records. r=bagder

Split nsHostRecord into AddrHostRecord and TypeHostRecord for standard address dns queries and queries by-type.

Comment 8

[Dragana Damjanovic [:dragana]]

Attachment: bug_1481251_tele_request.txt

Comment 9

[--]

Comment on attachment 9009875 [details]
Bug 1481251 - Optimize non-A/AAAA type DNS records. r=bagder

Daniel Stenberg [:bagder] has approved the revision.

Comment 10

[François Marier [:francois]]

Comment on attachment 9009876 [details]
bug_1481251_tele_request.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Dragana?

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 11

[Dragana Damjanovic [:dragana]]

(In reply to François Marier [:francois] from comment #10)
> Comment on attachment 9009876 [details]
> bug_1481251_tele_request.txt
> 
> 1) Is there or will there be **documentation** that describes the schema for
> the ultimate data set available publicly, complete and accurate?
> 
> Yes, in Histograms.json.
> 
> 2) Is there a control mechanism that allows the user to turn the data
> collection on and off?
> 
> Yes, telemetry setting.
> 
> 3) If the request is for permanent data collection, is there someone who
> will monitor the data over time?**
> 
> Yes, Dragana?
> 

Yes, I will monitor the data.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72d92155fb64
Optimize non-A/AAAA type DNS records. r=bagder

Comment 13

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 72d92155fb64 (Bug 1481251) for bc assertion failures in /obj-firefox/dist/include/mozilla/TimeStamp.h. 

Backout: https://hg.mozilla.org/integration/autoland/rev/d58b290f0bd7177bb8c23c28504890025a1515ea

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending,running,success,testfailed,busted,exception&revision=72d92155fb642884e7295ca9be6923f8f75d30b3&selectedJob=201830045

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=201830045&repo=autoland&lineNumber=17038

Comment 14

[Dragana Damjanovic [:dragana]]

It was typo :) I have fix the test. Thanks.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab11bd42e90c
Optimize non-A/AAAA type DNS records. r=bagder

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ab11bd42e90c