Closed Bug 1481393 Opened 2 years ago Closed 2 years ago

Implement a listener for WebVR PresentationGenerationContext changes

Categories

(Core :: WebVR, enhancement)

All
Unspecified
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: imanol, Assigned: imanol)

Details

(Whiteboard: [geckoview:fxr:p1])

Attachments

(1 file)

On FirefoxReality we increate mPresentingGeneration value to exit from WebVR from a back button action. This normally works but I did some tests with webpages that don't call vrDisplay.SubmitFrame and Exit from WebVR didn´t work ok.

The problem is that mPresentingGeneration changes are only checked in VRDisplay::SubmitFrame(). We should add a listener dispatch by the watchdog also to protect from situations where vrDisplay.SubmitFrame() is not called.
Whiteboard: [geckoview:fxr:p1]
MozReview-Commit-ID: FAR1fYnNM0U
Since this patch touches dom/base/nsGlobalWindowInner.[h,cpp] you need a peer review. Maybe ehsan?
Assignee: nobody → imanol
Comment on attachment 8998127 [details]
Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes;

Randall Barker [:rbarker] has approved the revision.

https://phabricator.services.mozilla.com/D2832
Attachment #8998127 - Flags: review+
Comment on attachment 8998127 [details]
Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes;

:kip (Kearwood Gilbert) has approved the revision.

https://phabricator.services.mozilla.com/D2832
Attachment #8998127 - Flags: review+
I was told :nika is the correct peer to request the review from.
Comment on attachment 8998127 [details]
Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes;

:Nika Layzell has approved the revision.
Attachment #8998127 - Flags: review+
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/56bf1095268f
Implement a listener for WebVR PresentationGenerationContext changes; r=kip,rbarker,nika
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/56bf1095268f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
status-firefox62=wontfix because we don't need to uplift this fix to GV 62 Beta.
You need to log in before you can comment on or make changes to this bug.