1481393 - Implement a listener for WebVR PresentationGenerationContext changes

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Imanol Fernandez]

On FirefoxReality we increate mPresentingGeneration value to exit from WebVR from a back button action. This normally works but I did some tests with webpages that don't call vrDisplay.SubmitFrame and Exit from WebVR didn´t work ok.

The problem is that mPresentingGeneration changes are only checked in VRDisplay::SubmitFrame(). We should add a listener dispatch by the watchdog also to protect from situations where vrDisplay.SubmitFrame() is not called.

Comment 1

[Imanol Fernandez]

Attachment: Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes;

MozReview-Commit-ID: FAR1fYnNM0U

Comment 2

[Randall Barker [:rbarker]]

Since this patch touches dom/base/nsGlobalWindowInner.[h,cpp] you need a peer review. Maybe ehsan?

Comment 3

[Phabricator Automation]

Comment on attachment 8998127 [details]
Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes;

Randall Barker [:rbarker] has approved the revision.

https://phabricator.services.mozilla.com/D2832

Comment 4

[Phabricator Automation]

Comment on attachment 8998127 [details]
Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes;

:kip (Kearwood Gilbert) has approved the revision.

https://phabricator.services.mozilla.com/D2832

Comment 5

[Randall Barker [:rbarker]]

I was told :nika is the correct peer to request the review from.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8998127 [details]
Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes;

:Nika Layzell has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56bf1095268f
Implement a listener for WebVR PresentationGenerationContext changes; r=kip,rbarker,nika

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/56bf1095268f

Comment 9

[Chris Peterson [:cpeterson]]

status-firefox62=wontfix because we don't need to uplift this fix to GV 62 Beta.