1481425 - Automatically remove git-mozreview commit-msg-hook from .git/hooks/commit-msg

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Rob Wu [:robwu]]

I use git-cinnabar and am migrating from mozreview to the Phabricator-based workflow.

I am manually removing the git-mozreview hook from .git/hooks/commit-msg [1], but I think that this should be done automatically to avoid unnecessary "MozReview-Commit-ID" line in commit messages from those who aren't aware of the commit hook.

Here are several examples of commit messages that contain both MozReview-Commit-ID and a Phabricator reference: https://hg.mozilla.org/mozilla-central/log/a89f17d30427


[1] https://hg.mozilla.org/hgcustom/version-control-tools/file/8f356a8585f1/git/hooks/commit-msg-mozreview

Comment 1

[Mark Côté [:mcote]]

Discussed on IRC.  mach vcs-setup seems like a good way to strip this out.

Comment 2

[Mark Côté [:mcote]]

Would you mind handling this at some point?

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: Bug 1481425: remove git-mozreview commit message hook during `mach vcs-setup` r?gps,mcote

During the MozReview days, users of git-cinnabar would install a
commit message hook to include `MozReview-Commit-Id` in their
commit messages. MozReview has seen been retired, yet there
are still a few users with the hook in their configs who now
have both a MozReview commit ID and a Phabricator Differential
link in their commits. This commit makes `mach vcs-setup` (and
`mach bootstrap`, since the former is called during the latter)
remove the commit hook on git checkouts of a Firefox repo.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d2c2019682
remove git-mozreview commit message hook during `mach vcs-setup` r=mcote,gps

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/03d2c2019682

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1481425: Deletes automated removal of mozreview commit hook r?sheehan

When moving from mozreview to Phabricator, the old mozreview git hook
had to be removed. Logic to automate the removal of this hook was added
to vcs-setup.

This commit removes this automated removal since it has been 2 years
since it landed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b53a32cabd7c
Deletes automated removal of mozreview commit hook r=sheehan

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b53a32cabd7c