1481445 - Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P2)

Description

[Mark Banner (:standard8)]

In our quest to stop relying on ids for bookmarks, we're now close enough to being able to start removing some of the built-in folder root id helpers, or at least some of the usages.

For mobileFolderId we can replace everything - the main use of it at the moment is for PU.promiseBookmarksTree (easy to replace with guids), and PU.isRootItem. 

isRootItem is also easy, though one of the tests really needed an update for async usage.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1481445 - Replace usage of the old bookmark ids in promiseBookmarksTree with guids.

MozReview-Commit-ID: AgqSKneywM4

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1481445 - Remove the id option for PlacesUtils.isRootItem (guids only accepted).

Depends on D2850

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1481445 - Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId.

Depends on D2851

Comment 4

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46ce4ebceb3158380b5d3e61bf7f8bf815cb07f5

Comment 5

[Phabricator Automation]

Comment on attachment 8998166 [details]
Bug 1481445 - Replace usage of the old bookmark ids in promiseBookmarksTree with guids.

Lina Cambridge (she/her) [:lina] has approved the revision.

https://phabricator.services.mozilla.com/D2850

Comment 6

[Phabricator Automation]

Comment on attachment 8998168 [details]
Bug 1481445 - Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId.

Lina Cambridge (she/her) [:lina] has approved the revision.

https://phabricator.services.mozilla.com/D2852

Comment 7

[Phabricator Automation]

Comment on attachment 8998167 [details]
Bug 1481445 - Remove the id option for PlacesUtils.isRootItem (guids only accepted).

Lina Cambridge (she/her) [:lina] has approved the revision.

https://phabricator.services.mozilla.com/D2851

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1e58f3dad7
Replace usage of the old bookmark ids in promiseBookmarksTree with guids. r=lina

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7e3e9bba8e0
Remove the id option for PlacesUtils.isRootItem (guids only accepted). r=lina

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b2f2e3b2bae
Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId. r=lina

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bb1e58f3dad7
https://hg.mozilla.org/mozilla-central/rev/d7e3e9bba8e0
https://hg.mozilla.org/mozilla-central/rev/0b2f2e3b2bae