Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId

RESOLVED FIXED in Firefox 63

Status

()

P2
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 1 bug)

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(3 attachments)

(Assignee)

Description

5 months ago
In our quest to stop relying on ids for bookmarks, we're now close enough to being able to start removing some of the built-in folder root id helpers, or at least some of the usages.

For mobileFolderId we can replace everything - the main use of it at the moment is for PU.promiseBookmarksTree (easy to replace with guids), and PU.isRootItem. 

isRootItem is also easy, though one of the tests really needed an update for async usage.
(Assignee)

Updated

5 months ago
Priority: -- → P2
Whiteboard: [fxsearch]
(Assignee)

Comment 1

5 months ago
Created attachment 8998166 [details]
Bug 1481445 - Replace usage of the old bookmark ids in promiseBookmarksTree with guids.

MozReview-Commit-ID: AgqSKneywM4
(Assignee)

Comment 2

5 months ago
Created attachment 8998167 [details]
Bug 1481445 - Remove the id option for PlacesUtils.isRootItem (guids only accepted).

Depends on D2850
(Assignee)

Comment 3

5 months ago
Created attachment 8998168 [details]
Bug 1481445 - Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId.

Depends on D2851
Comment on attachment 8998166 [details]
Bug 1481445 - Replace usage of the old bookmark ids in promiseBookmarksTree with guids.

Lina Cambridge (she/her) [:lina] has approved the revision.

https://phabricator.services.mozilla.com/D2850
Attachment #8998166 - Flags: review+
Comment on attachment 8998168 [details]
Bug 1481445 - Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId.

Lina Cambridge (she/her) [:lina] has approved the revision.

https://phabricator.services.mozilla.com/D2852
Attachment #8998168 - Flags: review+
Comment on attachment 8998167 [details]
Bug 1481445 - Remove the id option for PlacesUtils.isRootItem (guids only accepted).

Lina Cambridge (she/her) [:lina] has approved the revision.

https://phabricator.services.mozilla.com/D2851
Attachment #8998167 - Flags: review+

Comment 8

5 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb1e58f3dad7
Replace usage of the old bookmark ids in promiseBookmarksTree with guids. r=lina

Comment 9

5 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7e3e9bba8e0
Remove the id option for PlacesUtils.isRootItem (guids only accepted). r=lina

Comment 10

5 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b2f2e3b2bae
Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId. r=lina

Comment 11

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bb1e58f3dad7
https://hg.mozilla.org/mozilla-central/rev/d7e3e9bba8e0
https://hg.mozilla.org/mozilla-central/rev/0b2f2e3b2bae
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.