1481447 - Switch browser.search.log to a lazy preference getter.

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

We should switch browser.search.log to use a lazy preference getter instead of checking the value on every log.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1481447 - Switch search logging to a lazy pref.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8998359 [details]
Bug 1481447 - Switch search logging to a lazy pref.

Florian Quèze [:florian] has approved the revision.

Comment 3

[Johann Hofmann [:johannh]]

Hi Mike, is this ready for landing?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f016db59904
Switch search logging to a lazy pref. r=florian

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5f016db59904

Comment 6

[Mike Kaply [:mkaply]]

> Hi Mike, is this ready for landing?

Thanks for the reminder. I'd lost this in the shuffle.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift?

Comment 8

[Mike Kaply [:mkaply]]

> Is this something we should consider for Beta uplift?

There's really no harm in it. Makes logging search easier.

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 8998359 [details]
Bug 1481447 - Switch search logging to a lazy pref.

Approval Request Comment
[Feature/Bug causing the regression]: Clean up search logging
[User impact if declined]: None
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only impacts logging.
[String changes made/needed]:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8998359 [details]
Bug 1481447 - Switch search logging to a lazy pref.

A bit of logging code cleanup which also fixes some intermittents. Approved for 62.0b20.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a66a81d4d90a