Closed Bug 1481447 Opened 6 years ago Closed 6 years ago

Switch browser.search.log to a lazy preference getter.

Categories

(Firefox :: Search, enhancement, P3)

Product:
Firefox
Component:
Search
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(1 file)

Bug 1481447 - Switch search logging to a lazy pref.
46 bytes, text/x-phabricator-request
florian
: review+
RyanVM
: approval-mozilla-beta+
Details | Review 
We should switch browser.search.log to use a lazy preference getter instead of checking the value on every log.
Status: NEW → ASSIGNED
Comment on attachment 8998359 [details]
Bug 1481447 - Switch search logging to a lazy pref.

Florian Quèze [:florian] has approved the revision.
Attachment #8998359 - Flags: review+
Hi Mike, is this ready for landing?
Flags: needinfo?(mozilla)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/5f016db59904
Switch search logging to a lazy pref. r=florian
https://hg.mozilla.org/mozilla-central/rev/5f016db59904
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
> Hi Mike, is this ready for landing?

Thanks for the reminder. I'd lost this in the shuffle.
Flags: needinfo?(mozilla)
Is this something we should consider for Beta uplift?
Flags: needinfo?(mozilla)
> Is this something we should consider for Beta uplift?

There's really no harm in it. Makes logging search easier.
Flags: needinfo?(mozilla)
Comment on attachment 8998359 [details]
Bug 1481447 - Switch search logging to a lazy pref.

Approval Request Comment
[Feature/Bug causing the regression]: Clean up search logging
[User impact if declined]: None
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only impacts logging.
[String changes made/needed]:
Attachment #8998359 - Flags: approval-mozilla-beta?
Comment on attachment 8998359 [details]
Bug 1481447 - Switch search logging to a lazy pref.

A bit of logging code cleanup which also fixes some intermittents. Approved for 62.0b20.
Attachment #8998359 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: