1481499 - Intermittent Failures bot did not set disable-recommended

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Geoff Brown [:gbrown]]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1473173#c16 (and some earlier comments), the bot has commented "This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed." but failed to update the whiteboard with [stockwell:disable-recommended].

Actually, I haven't noticed any recent disabled-recommended changes to the whiteboard.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3887

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8998375 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3887

I left a comment in the code about one little thing.  But overall looks good.  I admit, though, I don't have a lot of context in this area.  So I'll leave it to Geoff to determine that it will "do the right thing."  :)

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 8998375 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3887

This looks fine. 

When testing in weekly mode, expect to see a few bugs, with lots of failures, change to [stockwell disable-recommended], and some, with less but still significant failures, change to [stockwell needswork] or [stockwell needswork:owner]. If you are seeing too many -- or not enough -- whiteboard changes, or anything looks suspicious, I'm happy to have a closer look.

Comment 4

[Sarah Clements [:sclements]]

hrm, running in test mode I see comments for 1,279 bugs most of which have don't have a whiteboard, or a whiteboard that won't update but several that would update to:

[stockwell disable-recommended] - 7 bugs total
[stockwell needswork:owner] - 2 bugs total
[stockwell unknown] - 9 bugs total

Does this sound right?

Comment 5

[Geoff Brown [:gbrown]]

Yes, I think that is reasonable.

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/45c70bbb03f74f8f9dc74d4ca401f260ddf86c27
Bug 1481499 - refactor whiteboard in commenter (#3887)

* Bug 1481499 - refactor whiteboard in commenter
Refactor how bug_info is retrieved and whiteboard
status is assigned. Clean up other helper functions
including assign_priority and check_needswork, to
avoid passing in unnecessary variables. Add comments
for clarity as needed pertaining to whiteboard assignment.