Closed
Bug 1481548
Opened 6 years ago
Closed 6 years ago
Implement a comparison function for SdpFmtpAttributeList
Categories
(Core :: WebRTC: Signaling, enhancement, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: johannes.willbold, Assigned: drno)
Details
Attachments
(1 file, 1 obsolete file)
According to the telemetry data, the serialization of the fmtp-attribute seems sometimes (0.02%) to neither match the sipcc-serialization nor the original SDP. We need a more sophisticated comparison operation to check whether there are actual differences.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → johannes.willbold
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Reporter | ||
Comment 1•6 years ago
|
||
Added additional fmtp comparison for the parsing resutl comparer by implementing the C++ == operator for SdpFmtpAttributeList. MozReview-Commit-ID: GJV2m9qz1m0
Updated•6 years ago
|
Attachment #8998632 -
Attachment description: Added additonal comprison for fmtp → Added additonal comparison for fmtp
Comment 2•6 years ago
|
||
Comment on attachment 8998632 [details]
Added additonal comparison for fmtp
Byron Campen [:bwc] has approved the revision.
Attachment #8998632 -
Flags: review+
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15f01b2209a7ea8349824dea1d9e2fbb95ac48a2
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=974a9cc8357404f092e4ef3246bd2723900f0a5b
Assignee | ||
Comment 5•6 years ago
|
||
Added additional fmtp comparison for the parsing resutl comparer by implementing the C++ == operator for SdpFmtpAttributeList.
Assignee | ||
Updated•6 years ago
|
Attachment #8998632 -
Attachment is obsolete: true
Comment 6•6 years ago
|
||
Comment on attachment 8999675 [details] Bug 1481548: Added additonal comparison for fmtp Byron Campen [:bwc] has approved the revision.
Attachment #8999675 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Assignee: johannes.willbold → drno
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5db1348b915f Added additonal comparison for fmtp r=bwc
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5db1348b915f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•