Closed Bug 1481548 Opened Last year Closed Last year

Implement a comparison function for SdpFmtpAttributeList

Categories

(Core :: WebRTC: Signaling, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: johannes.willbold, Assigned: drno)

Details

Attachments

(1 file, 1 obsolete file)

According to the telemetry data, the serialization of the fmtp-attribute seems sometimes (0.02%) to neither match the sipcc-serialization nor the original SDP. We need a more sophisticated comparison operation to check whether there are actual differences.
Assignee: nobody → johannes.willbold
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Attached file Added additonal comparison for fmtp (obsolete) —
Added additional fmtp comparison for the parsing resutl comparer by
implementing the C++ == operator for SdpFmtpAttributeList.

MozReview-Commit-ID: GJV2m9qz1m0
Attachment #8998632 - Attachment description: Added additonal comprison for fmtp → Added additonal comparison for fmtp
Comment on attachment 8998632 [details]
Added additonal comparison for fmtp

Byron Campen [:bwc] has approved the revision.
Attachment #8998632 - Flags: review+
Added additional fmtp comparison for the parsing resutl comparer by
implementing the C++ == operator for SdpFmtpAttributeList.
Attachment #8998632 - Attachment is obsolete: true
Comment on attachment 8999675 [details]
Bug 1481548: Added additonal comparison for fmtp

Byron Campen [:bwc] has approved the revision.
Attachment #8999675 - Flags: review+
Assignee: johannes.willbold → drno
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5db1348b915f
Added additonal comparison for fmtp r=bwc
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5db1348b915f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.