1481577 - GDB printing for hash tables is broken

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I tried to print a value that contains an XPCOM hash table, and:

  mBlockers = nsTHashtable<nsUint64HashKey>Traceback (most recent call last):
  File "third_party/python/gdbpp/gdbpp/thashtable.py", line 109, in children
    capacity = 1 << (table['kHashBits'] - table['mHashShift'])
gdb.error: There is no member or method named kHashBits.

It looks like kHashBits was renamed in bug 1477626 (in the “introduce mozilla::HashNumber” patch).

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make nsTHashtable pretty-printer aware of naming changes

kHashBits was renamed to mozilla::kHashNumberBits, which seems awkward
to access from the pretty-printer.  So we compute its value from the
HashNumber type instead.

Comment 2

[Tom Tromey :tromey]

Comment on attachment 9027539 [details] [diff] [review]
make nsTHashtable pretty-printer aware of naming changes

Review of attachment 9027539 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this.  This looks good to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/73de720af49d
make nsTHashtable pretty-printer aware of naming changes; r=tromey

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/73de720af49d

Comment 5

[Nicholas Nethercote [inactive]]

Would it be possible to write a test that would catch this kind of breakage?