Closed Bug 1481691 Opened 6 years ago Closed 6 years ago

Follow-up works for adb helper functions importing

Categories

(DevTools :: about:debugging, enhancement)

Product:
DevTools
Component:
about:debugging
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file, 8 obsolete files)

Bug 1481691 - Add a preference for the devtools-adb-extension id. r=jdescottes
46 bytes, text/x-phabricator-request
jdescottes
: review+
Details | Review
* Define a new preference for the devtools-adb extension id. (bug 1469054 comment 51) * Opt-in output log message (bug 1469054 comment 51) * Use require() instead of ChromeUtils.import (bug 1469054 comment 52) * Consider doing an optimization to skip extracting binaries (bug 1469054 comment 52) * Drop code for supporting older versions of Firefox (bug 1469054 comment 52) * Refactor devtools/shared/adb/adb.js since it's pretty long (bug 1469054 comment 52) * Audit which Promise should be used (bug 1469054 comment 52) * Drop code for FirefoxOS (bug 1469054 comment 64)
(In reply to Hiroyuki Ikezoe (:hiro) (PTO on Aug 20) from comment #0) > * Use require() instead of ChromeUtils.import (bug 1469054 comment 52) I've done this locally in the patch for bug 1469054, since it seems that ChromeUtils can't be used there. Maybe a similar issue of bug 1434543?
* Drop sync argument from kill() function (bug 1469054 comment 55).
(In reply to Hiroyuki Ikezoe (:hiro) (PTO on Aug 20) from comment #3) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=d9223be851747ab9ce47e8fe10fd51b68cbec987 Forgot to add one more patch there. https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eed23b2e0b1fcd454e68c305dd9457d20bce2f2
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Depends on D3081
Gah, moz-phab failed in the middle of publishing because there was a commit with non-existent reviewer. :/
As far as I can tell they were all for FirefoxOS. Depends on D3082
Depends on D3085
We've been using them as synchrous mode only. Depends on D3086
In the next patch, we will extract manifest.json in the extension into the profile directory. And returning a boolean will make getFileForBinary() simple with the extension version check which will be also introduced in the next patch. Depends on D3088
getManifestFromUnpacked() and isUnpacked() are mostly the same as they are in binary-manager.js [1] in the adbhelper addon. A big difference is that the manifest.json copied from the extension is the manifest.json for the devtools-adb-extension itself, not manifest.json(s) in a subdirectory for each platforms (e.g. linux/manifest.json). Due to the verion check in each xpcshell test needs to use a different version for the test extension, otherwise subsequent tests will use unpacked files in the first test case, thus the ADB mock won't be used at all. [1] https://github.com/mozilla/adbhelper/blob/0821424b6b895645560089a134054b35b6649ff8/binary-manager.js Depends on D3089
Comment on attachment 8999104 [details] Bug 1481691 - Add a preference for the devtools-adb-extension id. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999104 - Flags: review+
Comment on attachment 8999105 [details] Bug 1481691 - Replace console.log and console.debug with dumpn. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999105 - Flags: review+
Comment on attachment 8999106 [details] Bug 1481691 - Drop code and comments for older versions of Firefox. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999106 - Flags: review+
Comment on attachment 8999107 [details] Bug 1481691 - Drop code for FirefoxOS. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999107 - Flags: review+
Comment on attachment 8999111 [details] Bug 1481691 - Use Promise instead of PromiseUtils. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999111 - Flags: review+
Comment on attachment 8999113 [details] Bug 1481691 - Drop |sync| argument from kill() and stop(). r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999113 - Flags: review+
Comment on attachment 8999114 [details] Bug 1481691 - Rename extractBinary to extractFiles and make it return a boolean instead of path string. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999114 - Flags: review+
Comment on attachment 8999110 [details] Bug 1481691 - Drop root relevant stuff and push and pull. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999110 - Flags: review+
Comment on attachment 8999116 [details] Bug 1481691 - Unpack files only if the devtools-adb-extension versionis mismatch or there are no unpacked files. r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #8999116 - Flags: review+
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d9b92929815 Add a preference for the devtools-adb-extension id. r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/59dae312f47b Replace console.log and console.debug with dumpn. r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/0d6fb76b026b Drop code and comments for older versions of Firefox. r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/fa083919718a Drop code for FirefoxOS. r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/0ce06cc7f5d7 Drop root relevant stuff and push and pull. r=jedescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/70b0f635cc4d Use Promise instead of PromiseUtils. r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/e73c07a618a7 Drop |sync| argument from kill() and stop(). r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/4c351951fd42 Rename extractBinary to extractFiles and make it return a boolean instead of path string. r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/32ad5fef292a Unpack files only if the devtools-adb-extension versionis mismatch or there are no unpacked files. r=jdescottes
Summary: Follow-up works for adb helper functions impoting → Follow-up works for adb helper functions importing
Comment on attachment 8999105 [details] Bug 1481691 - Replace console.log and console.debug with dumpn. r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999105 - Flags: review+
Attachment #8999105 - Attachment is obsolete: true
Comment on attachment 8999106 [details] Bug 1481691 - Drop code and comments for older versions of Firefox. r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999106 - Flags: review+
Attachment #8999106 - Attachment is obsolete: true
Comment on attachment 8999107 [details] Bug 1481691 - Drop code for FirefoxOS. r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999107 - Flags: review+
Attachment #8999107 - Attachment is obsolete: true
Comment on attachment 8999110 [details] Bug 1481691 - Drop root relevant stuff and push and pull. r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999110 - Flags: review+
Attachment #8999110 - Attachment is obsolete: true
Comment on attachment 8999111 [details] Bug 1481691 - Use Promise instead of PromiseUtils. r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999111 - Flags: review+
Attachment #8999111 - Attachment is obsolete: true
Comment on attachment 8999113 [details] Bug 1481691 - Drop |sync| argument from kill() and stop(). r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999113 - Flags: review+
Attachment #8999113 - Attachment is obsolete: true
Comment on attachment 8999114 [details] Bug 1481691 - Rename extractBinary to extractFiles and make it return a boolean instead of path string. r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999114 - Flags: review+
Attachment #8999114 - Attachment is obsolete: true
Comment on attachment 8999116 [details] Bug 1481691 - Unpack files only if the devtools-adb-extension versionis mismatch or there are no unpacked files. r=jdescottes Julian Descottes [:jdescottes][:julian] has been removed from the revision.
Attachment #8999116 - Flags: review+
Attachment #8999116 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: