1481833 - SVG animVal breaks console

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Vitaliy Kanev]

Attachment: Test image

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704192850

Steps to reproduce:

1. Open the test case provided
2. Open developer tools, select "Console" tab
3. Type the following:
        document.querySelector("image");
4. Expand "image" tag -> href -> animVal


Actual results:

Console is no longer shown - we get a blank tab (<https://cdn.discordapp.com/attachments/346085743426273280/476751339045519360/2018-08-08_16-57-10.png>)


Expected results:

Something that I don't understand - animVal should be expanded

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Confirmed on Nightly - I'll have a look shortly

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

60 is not affected, but only because we couldn't expand the value.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1481833 - Fix expanding getter returning longString; r=Honza.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Okay, so this patch fixes the issue: https://phabricator.services.mozilla.com/D2949
I'm going to file an issue on Reps and see if there's a prettier way to get such getter (animVal gets send through rdp because it's a safe getter).

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

A PR was created in Reps https://github.com/devtools-html/debugger.html/pull/6785/files
I think we should try to link the attached patch here so we can request an uplift more easily.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8998556 [details]
Bug 1481833 - Fix expanding getter returning longString; r=Honza.

Jan Honza Odvarko [:Honza] has approved the revision.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8998556 [details]
Bug 1481833 - Fix expanding getter returning longString; r=Honza.

Why Phabricator creates a new `review` flag?
Is that known issue?

Honza

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a03fc28195e
Fix expanding getter returning longString; r=Honza.

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1a03fc28195e

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8998556 [details]
Bug 1481833 - Fix expanding getter returning longString; r=Honza.

Approval Request Comment
[Feature/Bug causing the regression]: Ability to expand a longString in the console
[User impact if declined]: Console crashes if user try to expand a getter returning a long string. This might not be frequent since we only evaluate getters which are known to be side-effect free.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes, see Comment 0 for STR
[List of other uplifts needed for the feature/fix]: -
[Is the change risky?]: I don't think so.
[Why is the change risky/not risky?]: The change is quite constrained, and there is a test makins sure everything works as expected
[String changes made/needed]: -

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8998556 [details]
Bug 1481833 - Fix expanding getter returning longString; r=Honza.

Fix for a dev tools crash, scope seems limited to dev tools console, let's uplift for beta 17.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe256fdb428c

Comment 13

[Stefan [:StefanG_QA]]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0 (20180813190114)

I was able to reproduce the mentioned behavior using Nightly build from 08/08/2018 and Beta 62.0b16 and the provided steps.

Using the latest Nightly and Beta 62.0b17 build, the issue is not reproducible anymore on Windows 10 x64, OS X 10.12 and Ubuntu 18.04 x64. When loading the provided picture and run "document.querySelector("image");" in the console I`m able to expand the "image" tag -> href -> animVal without any issue. The console is able to display the value of "animVal" correctly.