1481851 - getStats: kind is missing from RTPStreamStats

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Philipp Hancke [:fippo]]

I renamed mediaType to kind in https://github.com/w3c/webrtc-stats/issues/301
and that is now missing from RTCRtpStreamStats.

The old name will probably be around forever.

Comment 1

[Philipp Hancke [:fippo]]

Attachment: mediaType-kind.patch

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

WebIDL review information:
The field in question is defined in the WebRTC Stats spec[0] on the RTCRtpStreamStats dictionary [1]
The WebIDL changes confined to dom/webidl/RTCStatsReport.webidl [2]

[0] https://w3c.github.io/webrtc-stats/
[1] https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats
[2] https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/dom/webidl/RTCStatsReport.webidl#29

Comment 3

[Philipp Hancke [:fippo]]

Attachment: also adds (de)serialization for about:webrtc

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8998580 [details] [diff] [review]
also adds (de)serialization for about:webrtc

LGTM

Comment 5

[Philipp Hancke [:fippo]]

smaug, can you please take a look from a webidl point of view? Can reupload to phabricator too if I missed the deadline.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/87b754ac0db0
Add kind to RTCRtpStreamStats as alias to mediaType. r=ng,smaug

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/87b754ac0db0

Comment 8

[Eric Shepherd [:sheppy]]

Created a new page for RTCRtpStreamStats: https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpStreamStats
Added: https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpStreamStats/kind

The BCD data for this is added in PR #2802 on the BCD repo: https://github.com/mdn/browser-compat-data/pull/2802

I've also mentioned this on Firefox 63 for developers.