1481859 - When I open pdf link(from URLBar or Bookmarks/History), sometimes starts download instead open builtin pdf viewer.

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Alice0775 White]

This seems to be timing problem.
I think that it can be easily reproduced with a slow PC.
This seems resent regression since Nightly63? 
It does not seem to reproduce on 62.0b14.

Reproducible: easy to reproduce with a slow PC.

Steps To Reproduce:
(Preparation)
 Copy link http://moji.gr.jp/firefox/sample.pdf to clipboard
(Steps)
1. Start Firefox
2. Immediately after UI ready, right click on URLBar and Choose "Paste and Go"
or
2. Immediately after UI ready,  hit Ctrl+V and Enter

OR
(Preparation)
 Bookmarked http://moji.gr.jp/firefox/sample.pdf
1. Start Firefox
2. Immediately after UI ready, click on the bookmark

Actual Results:
PDF will be downloaded without prompt

Expected Results:
The pdf opens in built-in PDF viewer

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=15bfb5802548bef7c5424add0840ea3281617e3f&tochange=f5e9e5994a5d2dcfa1fe83c19101bb92cdf7ff4c

Regressed by:
f5e9e5994a5d	Kris Maglione — Bug 1479245: Don't eagerly load any PDF.js scripts in the content process. r=bdahl


:kmag,
Your patch seems to cause the regression, could you please look into this?

Comment 2

[Gary [:streetwolf52]]

I have no problems opening up pdfs by clicking on links.  However, when I click on an external pdf file in Windows the file downloads, sometimes without the arrow turning blue, and there is no pdf file on screen.  Clicking on the download arrow and selecting the pdf opens it. Every now and then external pdfs work as expected but this is rare.

Comment 3

[Alice0775 White]

Yep, I can also reproduce the problem when start Firefox with commandline option as follows.

> firefox.exe PathToPdf.pdf

And I get same a same regression window,

Comment 4

[Gary [:streetwolf52]]

Is anyone looking into this?  Should my problem have a new bug report?  I discovered that if I already have Fx opened clicking on an external pdf file will create a new tab and display the pdf.  Tried all my testing with a new profile.

Comment 5

[Marcia Knous [:marcia]]

Per triage team, asking Brendan to have someone take a look at this and prioritize it. Thanks!

Comment 6

[Brendan Dahl [:bdahl]]

I pinged kmag and he plans to look into this today.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked since this is a recent regression in 63.

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1481859: Initialized PdfJs sharedData state earlier in startup. r=bdahl

Comment 9

[Gary [:streetwolf52]]

(In reply to Kris Maglione [:kmag] from comment #8)
> Created attachment 9004025 [details]
> Bug 1481859: Initialized PdfJs sharedData state earlier in startup. r=bdahl

Brendan is away until 9/4.  Can someone else approve this change so we can get it sooner?

Comment 10

[Brendan Dahl [:bdahl]]

Comment on attachment 9004025 [details]
Bug 1481859: Initialized PdfJs sharedData state earlier in startup. r=bdahl

Brendan Dahl [:bdahl] has approved the revision.

Comment 11

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4400f4e6b8500d2a7ebaacbaa1a361f18c9feac
Bug 1481859: Initialized PdfJs sharedData state earlier in startup. r=bdahl

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f4400f4e6b85

Comment 13

[kernp25]

Can this be uplifted to Firefox 63?

Comment 14

[Pascal Chevrel:pascalc]

Kris, can you uplift to beta please? Thanks

Comment 15

[Pascal Chevrel:pascalc]

Kris, could you uplift this patch to beta please? Thanks

Comment 16

[Pascal Chevrel:pascalc]

Marking as wontfix for 63 as we are now in the last week of betas before RC week.

Comment 17

[Kris Maglione [:kmag]]

Comment on attachment 9004025 [details]
Bug 1481859: Initialized PdfJs sharedData state earlier in startup. r=bdahl

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1479245

User impact if declined: This issue causes PDFs to sometimes fail to open correctly during startup.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: Bug 1489072

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It's a relatively simple change to make sure we initialize PDF.js settings early enough

String changes made/needed:

Comment 18

[Pascal Chevrel:pascalc]

Comment on attachment 9004025 [details]
Bug 1481859: Initialized PdfJs sharedData state earlier in startup. r=bdahl

Minimal patch fixing a tracked 63 regression, approved for uplift to our last 63 beta. Thanks.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6b6ccb319ba

Comment 20

[Cristian Craciun]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20181011220118

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20181011200118

Verified as fixed on the latest Nightly build (2018-10-12) and on the latest Beta build (v63beta14).